From b7c80888a6f74eca501c1dfa78a7f6074bd94c70 Mon Sep 17 00:00:00 2001 From: katthomas Date: Fri, 28 Oct 2016 13:01:02 -0700 Subject: [PATCH] Log error message if os.rename fails R=agable@google.com BUG=659178 Review-Url: https://codereview.chromium.org/2448983004 --- recipe_modules/bot_update/resources/bot_update.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/recipe_modules/bot_update/resources/bot_update.py b/recipe_modules/bot_update/resources/bot_update.py index 321136966..aa7728947 100755 --- a/recipe_modules/bot_update/resources/bot_update.py +++ b/recipe_modules/bot_update/resources/bot_update.py @@ -299,7 +299,11 @@ def remove(target): os.makedirs(dead_folder) dest = path.join(dead_folder, uuid.uuid4().hex) print 'Marking for removal %s => %s' % (target, dest) - os.rename(target, dest) + try: + os.rename(target, dest) + except Exception as e: + print 'Error renaming %s to %s: %s' % (target, dest, str(e)) + raise def ensure_no_checkout(dir_names):