From b460ebe72348da309ae98e54acf55d4311db594c Mon Sep 17 00:00:00 2001 From: "scottmg@chromium.org" Date: Mon, 24 Feb 2014 22:08:09 +0000 Subject: [PATCH] Don't have svn ls block waiting for password If user is unauthenticated, svn ls would just hang waiting at "Password for 'User':", now it'll correctly fail with "svn: Can't get password". R=iannucci@chromium.org BUG=323300,346472 Review URL: https://codereview.chromium.org/178763003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@253004 0039d316-1c4b-4281-b951-d872f2087c98 --- win_toolchain/get_toolchain_if_necessary.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/win_toolchain/get_toolchain_if_necessary.py b/win_toolchain/get_toolchain_if_necessary.py index fb18ffc43..033c09101 100755 --- a/win_toolchain/get_toolchain_if_necessary.py +++ b/win_toolchain/get_toolchain_if_necessary.py @@ -121,7 +121,7 @@ def HaveSrcInternalAccess(): """Checks whether access to src-internal is available.""" with open(os.devnull, 'w') as nul: if subprocess.call( - ['svn', 'ls', + ['svn', 'ls', '--non-interactive', 'svn://svn.chromium.org/chrome-internal/trunk/src-internal/'], shell=True, stdin=nul, stdout=nul, stderr=nul) == 0: return True