From ae21f6a5ec30b63e4b8405fc5a783eb242ef10c5 Mon Sep 17 00:00:00 2001 From: Chenlin Fan Date: Thu, 6 Jul 2023 02:00:45 +0000 Subject: [PATCH] New vpython to depot_tools 1. virtualenv field in the spec is ignored. 2. --vpython-tool removed support for delete and help subcommands. 3. --vpython-tool installed removed support for naming venv. 4. removed support for -vpython-interpreter. 5. removed support for searching interpreters in host PATH. 6. python 2.7 is available only if the binary is invoked as `vpython`. 7. fixed a bug that passes invalid vpython arguments to the script, which may be silently ignored. 8. python_version in the vpython_spec must specify a minor version (python_version: "3" is not valid anymore). 9. vpython now requires the cipd binary to be present in PATH, which is true already when using Swarming or depot_tools. Also updates the LUCI_OWNERS to add peep-software-deploy team. Bug:1415212 Change-Id: I295c1aad1516a0c36eefa2ae04e85cabb518bda8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4653897 Reviewed-by: Robbie Iannucci Commit-Queue: Chenlin Fan --- LUCI_OWNERS | 2 ++ cipd_manifest.txt | 2 +- cipd_manifest.versions | 56 +++++++++++++++++++++--------------------- 3 files changed, 31 insertions(+), 29 deletions(-) diff --git a/LUCI_OWNERS b/LUCI_OWNERS index 33ae0aaa0..1fbf19586 100644 --- a/LUCI_OWNERS +++ b/LUCI_OWNERS @@ -6,3 +6,5 @@ jonahhooper@google.com randymaldonado@google.com yuanjunh@google.com yiwzhang@google.com +fancl@chromium.org +bryner@google.com diff --git a/cipd_manifest.txt b/cipd_manifest.txt index aa0a276fb..1f805b41c 100644 --- a/cipd_manifest.txt +++ b/cipd_manifest.txt @@ -36,7 +36,7 @@ $VerifiedPlatform linux-armv6l linux-mips64 linux-mips64le linux-mipsle $VerifiedPlatform windows-arm64 # vpython. -infra/tools/luci/vpython/${platform} git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 +infra/tools/luci/vpython/${platform} git_revision:d8bba723569a29332f58c37dfe03bed52193748c # LUCI editor infra/tools/luci/led/${platform} git_revision:6e9be28a4c4e3a804f400dc6c2ed08b866f0a38b diff --git a/cipd_manifest.versions b/cipd_manifest.versions index e6b9a9232..a0906f3e7 100644 --- a/cipd_manifest.versions +++ b/cipd_manifest.versions @@ -362,60 +362,60 @@ infra/tools/luci/lucicfg/windows-arm64 Si-ujQOKSkh7ukEjOgx9vgC4XayBSWJYCS5RiQ58UkMC infra/tools/luci/vpython/linux-386 - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - eGwM15U21ZJfAQUr3fwhBXJjbs0C9R5PhQ2s7ffJ5x4C + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + RSNnV_s4tgCDZApr_iy8gX1cTB-pfxpqP0Ld8Er5DtEC infra/tools/luci/vpython/linux-amd64 - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - 9yAXv0KsU9JAgagYQxkjWkU_YUDsDJpdQ4Rktg-EJDoC + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + ZwWW-ozIruVJJT0uwJOUhy63kyCOEw5cYaJlNUZHDGYC infra/tools/luci/vpython/linux-arm64 - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - caLUJKwXkeJqNbXe8VrUaJapyclM4Pi8UqrVMDYRvqMC + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + 27aQE7b4DHyAzoRFpBMIMXzi3fXDAiigGU1ocFmPfIIC infra/tools/luci/vpython/linux-armv6l - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - 4DqSKhlfFqV13-5gC0ocY9p6ywv-cJiL2NilLkppLiIC + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + Q_5hiZ_CJK-cg6VIupL0DE1ktBH8gM6qb0bD4BvI3YkC infra/tools/luci/vpython/linux-mips64 - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - N6eu72sj__hX71cv_zxtnmskb1JPT3H5peTA0A4hWQ4C + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + aNuklRCbwfIOqlnoXk-eOtZ11USldZ8Hwz2jWde8NrwC infra/tools/luci/vpython/linux-mips64le - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - 2fVbrtfqruPr0fCu6WzUd6F0ZzZOAeSewpvkvK9qvl0C + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + eaoFR2l7FCUw_rP85XN96e3tELkcUCs5NOTq0PNwQP4C infra/tools/luci/vpython/linux-mipsle - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - 44Pd9YZvAOGgXkir4GV_3nfWF6DFFOx91y7hrdeKCpgC + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + cmvXEgqMJbB4Kk_-7l_qldlcJCBZ-pztR8OWsUN7oLAC infra/tools/luci/vpython/linux-ppc64 - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - 2bF-o3-L4WWbUHR6SvsVUAq6X8ZcQvT0GD762sM2CYEC + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + niYGcWLdBRauMPDaswPEcw_iwME8DlTWQg45rbdGgkIC infra/tools/luci/vpython/linux-ppc64le - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - 5eTfzvKq0RH3XgWLuhKPyVFGwbYi3fWogKENRq2wx9MC + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + N2-z7aZ1P8aCYhUTqcCenflmO2hjrJjESfrS3ViUZHYC infra/tools/luci/vpython/linux-s390x - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - y8M08KKGmPcQtUc9O3ISZAvG0cXSDvevJrk59xhC9j0C + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + b6odf-GK3XuqFy2mmnq8GiKjdIRRtfAj0V-UQpWsMJgC infra/tools/luci/vpython/mac-amd64 - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - Jdog2fhqcbdX7c8uZTwC0ED0Z6Se8-Qj0IKZzzfkTqcC + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + TVckurEWQsaVCxqXJZHaAKm3cq2tm4ZHpi7xZ_-fQ-wC infra/tools/luci/vpython/mac-arm64 - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - 5od2TokCifZKqqmc-6P-rVJHCbq9-3ogCbY8M3SRFooC + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + QQ7FhTLLGyI990YxK9N3PJMnBAr4vVISg9d5SJIUZkAC infra/tools/luci/vpython/windows-amd64 - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - nRUaJj85Xfp87bEW6FjXOde90sf-KhSbhL0b08ZDXU8C + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + 82NqtTt4MMo-936-glrIXNuIrI95X0SXUdB-t_anrJQC infra/tools/luci/vpython/windows-arm64 - git_revision:7db81fdd219325d5d11fdaf56357ec28c26fffb3 - AHTqVMdkiBvkdKKoeo4Ib8z-ACkfIgRuKFos3WADrlAC + git_revision:d8bba723569a29332f58c37dfe03bed52193748c + rI7rm5yG8neDSbZEoX4UWoKts-B_z92aLb8nNPUCPvYC infra/tools/mac_toolchain/mac-amd64 git_revision:3e597065cb23c1fe03aeb2ebd792d83e0709c5c2