From ac6f623a29dac2d7b67b9439339dff859c2110c0 Mon Sep 17 00:00:00 2001 From: Jamie Madill Date: Wed, 7 Jul 2021 20:54:08 +0000 Subject: [PATCH] git cl: Ensure update before checking if "full" format. We found that in the bot environment sometimes we'd check the full format setting before doing a lazy config update. Adds an explicit call to ensure the lazy update. Fixes the problem of the bot environment not running the same format checks in some cases. Bug: 1219863 Change-Id: I970d97da462972300f52cbcb382f7da3929b73e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3009534 Auto-Submit: Jamie Madill Commit-Queue: Dirk Pranke Reviewed-by: Dirk Pranke --- git_cl.py | 1 + 1 file changed, 1 insertion(+) diff --git a/git_cl.py b/git_cl.py index 24e3b9a0f..6f5ea49e3 100755 --- a/git_cl.py +++ b/git_cl.py @@ -826,6 +826,7 @@ class Settings(object): def GetFormatFullByDefault(self): if self.format_full_by_default is None: + self._LazyUpdateIfNeeded() result = ( RunGit(['config', '--bool', 'rietveld.format-full-by-default'], error_ok=True).strip())