diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index 695393f0e..571772731 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -1029,7 +1029,10 @@ def CheckBuildbotPendingBuilds(input_api, output_api, url, max_pendings, def CheckDirMetadataFormat(input_api, output_api): - file_filter = lambda f: input_api.basename(f.LocalPath()) == 'DIR_METADATA' + # TODO(crbug.com/1102997): Remove OWNERS once DIR_METADATA migration is + # complete. + file_filter = lambda f: ( + input_api.basename(f.LocalPath()) in ('DIR_METADATA', 'OWNERS')) affected_files = set([ f.LocalPath() for f in input_api.change.AffectedFiles( @@ -1038,7 +1041,7 @@ def CheckDirMetadataFormat(input_api, output_api): if not affected_files: return [] - name = 'Validate DIR_METADATA files' + name = 'Validate metadata in OWNERS and DIR_METADATA files' dirmd_bin = 'dirmd.bat' if input_api.is_windows else 'dirmd' kwargs = {} if input_api.is_windows: diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py index 9b00784b6..7e2ffad95 100755 --- a/tests/presubmit_unittest.py +++ b/tests/presubmit_unittest.py @@ -2559,10 +2559,12 @@ the current line as well! 'a/DIR_METADATA': ('M', ''), 'a/b/OWNERS': ('M', ''), 'c/DIR_METADATA': ('D', ''), + 'd/unrelated': ('M', ''), }) dirmd_bin = 'dirmd.bat' if input_api.is_windows else 'dirmd' - expected_cmd = [dirmd_bin, 'validate', 'DIR_METADATA', 'a/DIR_METADATA'] + expected_cmd = [ + dirmd_bin, 'validate', 'DIR_METADATA', 'a/DIR_METADATA', 'a/b/OWNERS'] commands = presubmit_canned_checks.CheckDirMetadataFormat( input_api, presubmit.OutputApi)