From a5519ca8728983c295ec8fbeca8d4da72e530c3c Mon Sep 17 00:00:00 2001 From: Fumitoshi Ukai Date: Sun, 9 Feb 2025 23:21:47 -0800 Subject: [PATCH] post_build_ninja_summary: run siso.py instead of siso command Passing args via siso.bat is problematic. Invoke 'python3 siso.py' instead. Bug: 323780528 Change-Id: I991aeab375068d790f9e1f9fd264db9c1003f9dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6247814 Reviewed-by: Takuto Ikuta Auto-Submit: Fumitoshi Ukai Commit-Queue: Fumitoshi Ukai --- post_build_ninja_summary.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/post_build_ninja_summary.py b/post_build_ninja_summary.py index cba75b33d..909e9e1c7 100755 --- a/post_build_ninja_summary.py +++ b/post_build_ninja_summary.py @@ -57,6 +57,8 @@ import os import subprocess import sys +THIS_DIR = os.path.dirname(__file__) + # The number of long build times to report: long_count = 10 # The number of long times by extension to report @@ -362,8 +364,7 @@ def main(): long_ext_count += len(args.step_types.split(";")) if os.path.exists(metrics_file): - # Automatically handle summarizing siso builds. - cmd = ["siso.bat" if "win32" in sys.platform else "siso"] + cmd = [sys.executable, os.path.join(THIS_DIR, "siso.py")] cmd.extend(["metrics", "summary"]) if args.build_directory: cmd.extend(["-C", args.build_directory])