diff --git a/roll_dep.py b/roll_dep.py index 5e4a08e342..d34d467ffc 100755 --- a/roll_dep.py +++ b/roll_dep.py @@ -52,7 +52,7 @@ class AlreadyRolledError(Error): def check_output(*args, **kwargs): """subprocess.check_output() passing shell=True on Windows for git.""" kwargs.setdefault('shell', NEED_SHELL) - return subprocess.check_output(*args, **kwargs) + return subprocess.check_output(*args, **kwargs).decode('utf-8') def check_call(*args, **kwargs): diff --git a/tests/roll_dep_test.py b/tests/roll_dep_test.py index 2109051c55..2da96daddf 100644 --- a/tests/roll_dep_test.py +++ b/tests/roll_dep_test.py @@ -56,6 +56,10 @@ class RollDepTest(fake_repos.FakeReposTestBase): self.env = os.environ.copy() self.env['DEPOT_TOOLS_UPDATE'] = '0' self.env['DEPOT_TOOLS_METRICS'] = '0' + # Suppress Python 3 warnings and other test undesirables. + self.env['GCLIENT_TEST'] = '1' + + self.maxDiff = None self.enabled = self.FAKE_REPOS.set_up_git() self.src_dir = os.path.join(self.root_dir, 'src') @@ -73,6 +77,8 @@ class RollDepTest(fake_repos.FakeReposTestBase): stdout, stderr = process.communicate() logging.debug("XXX: %s\n%s\nXXX" % (' '.join(cmd), stdout)) logging.debug("YYY: %s\n%s\nYYY" % (' '.join(cmd), stderr)) + stdout = stdout.decode('utf-8') + stderr = stderr.decode('utf-8') return (stdout.replace('\r\n', '\n'), stderr.replace('\r\n', '\n'), process.returncode)