Make `git cl presubmit` pass before running `git cl upload`.
This check is making any script which runs `git cl presubmit` locally fail. In particular, `jj upload` runs `git cl presubmit`, and then uploads only if it succeeds (we cannot run `git cl upload`, because that can specifically only upload the currently checked out commit). According to the bug I linked, "I think that historically it was possible for developers to try to commit directly from their Chromium repo, without uploading, and this aims to stop that. It also warns users that their change has not been uploaded. Whether it still needs to be an error is not clear, but I'm not sure it's causing any problems so I'm inclined to leave it." To sum things up: * Since presubmits can be bypassed, this is not a security measure * These days I don't believe you can commit directly from your chromium repo * It's now starting to cause problems. Bug: 40253731 Change-Id: I0d83fa68d0e65dcdd8932c7d3053750dcc16d3fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6875404 Reviewed-by: Scott Lee <ddoman@chromium.org> Commit-Queue: Matt Stark <msta@google.com>changes/04/6875404/4
parent
226b785aa0
commit
9e9b885a7b
Loading…
Reference in New Issue