From 9e633036da7dc15616f173dbc7bd500594ac94d0 Mon Sep 17 00:00:00 2001 From: Bruce Dawson Date: Tue, 4 Aug 2020 21:50:29 +0000 Subject: [PATCH] Fix reference to enable_js_type_check A TODO in ninjalog_uploader.py referred to the closure_compile gn arg which was recently renamed (as of crrev.com/c/2248564) to enable_js_type_check. This updates it (and adds a missing space and a bug number). This is purely a comment fix. Change-Id: I117fa7910663491fd7c6e017fe98e2a977a75f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2336176 Commit-Queue: Bruce Dawson Auto-Submit: Bruce Dawson Reviewed-by: Edward Lesmes Reviewed-by: Takuto Ikuta --- ninjalog_uploader.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ninjalog_uploader.py b/ninjalog_uploader.py index 2db0155b9..e34839a92 100755 --- a/ninjalog_uploader.py +++ b/ninjalog_uploader.py @@ -29,7 +29,8 @@ import time import httplib2 # These build configs affect build performance a lot. -# TODO(tikuta): Add 'blink_symbol_level'and 'closure_compile'. +# TODO(https://crbug.com/900161): Add 'blink_symbol_level' and +# 'enable_js_type_check'. WHITELISTED_CONFIGS = ('symbol_level', 'use_goma', 'is_debug', 'is_component_build', 'enable_nacl', 'host_os', 'host_cpu', 'target_os', 'target_cpu')