From 9cb802ca48eb8f8ec22fe6f3f63fb29d33f4a7fd Mon Sep 17 00:00:00 2001 From: Michael Achenbach Date: Mon, 10 Jul 2017 08:56:57 +0200 Subject: [PATCH] Improve gerrit recipe_module example The /a suffix in the hots URL is not necessary as the gerrit_util adds it by default to authenticate. Having it hard-coded in the example can be misleading. Bug: 685318 Change-Id: I333cd8b2aa9020aadfd186f2e18fbff0aa917681 Reviewed-on: https://chromium-review.googlesource.com/564611 Reviewed-by: Andrii Shyshkalov Commit-Queue: Michael Achenbach --- .../recipe_modules/gerrit/examples/full.expected/basic.json | 6 +++--- recipes/recipe_modules/gerrit/examples/full.py | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/recipes/recipe_modules/gerrit/examples/full.expected/basic.json b/recipes/recipe_modules/gerrit/examples/full.expected/basic.json index 3d752b198..1c2a6ce81 100644 --- a/recipes/recipe_modules/gerrit/examples/full.expected/basic.json +++ b/recipes/recipe_modules/gerrit/examples/full.expected/basic.json @@ -6,7 +6,7 @@ "RECIPE_PACKAGE_REPO[depot_tools]/gerrit_client.py", "branch", "--host", - "https://chromium-review.googlesource.com/a", + "https://chromium-review.googlesource.com", "--project", "v8/v8", "--branch", @@ -37,7 +37,7 @@ "RECIPE_PACKAGE_REPO[depot_tools]/gerrit_client.py", "branchinfo", "--host", - "https://chromium-review.googlesource.com/a", + "https://chromium-review.googlesource.com", "--project", "v8/v8", "--branch", @@ -65,7 +65,7 @@ "RECIPE_PACKAGE_REPO[depot_tools]/gerrit_client.py", "changes", "--host", - "https://chromium-review.googlesource.com/a", + "https://chromium-review.googlesource.com", "--json_file", "/path/to/tmp/json", "--start", diff --git a/recipes/recipe_modules/gerrit/examples/full.py b/recipes/recipe_modules/gerrit/examples/full.py index ab9dfb486..48784a04e 100644 --- a/recipes/recipe_modules/gerrit/examples/full.py +++ b/recipes/recipe_modules/gerrit/examples/full.py @@ -8,7 +8,7 @@ DEPS = [ def RunSteps(api): - host = 'https://chromium-review.googlesource.com/a' + host = 'https://chromium-review.googlesource.com' project = 'v8/v8' branch = 'test'