From 90d54ff344a0e8188214058614b5bab46db5bf0e Mon Sep 17 00:00:00 2001 From: Ben Segall Date: Thu, 4 Apr 2024 14:12:58 +0000 Subject: [PATCH] [reclient] Limit local resource tuning on windows to cloudtops Bug: b/330173550 Change-Id: I65ce93eeb216a7a4b77506fbcb515697fdecde2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5420670 Commit-Queue: Ben Segall Reviewed-by: Michael Savigny --- reclient_helper.py | 23 ++++++++++++++++++++--- 1 file changed, 20 insertions(+), 3 deletions(-) diff --git a/reclient_helper.py b/reclient_helper.py index f60de3e5e4..8c832a6eed 100644 --- a/reclient_helper.py +++ b/reclient_helper.py @@ -274,13 +274,30 @@ def set_mac_defaults(): os.environ.setdefault("RBE_deps_cache_max_mb", "1024") +def is_win_ctop(): + if not sys.platform.startswith("win"): + return False + import winreg + try: + bios = winreg.OpenKeyEx(winreg.HKEY_LOCAL_MACHINE, + r"SOFTWARE\\GWindows") + model = winreg.QueryValueEx(bios, "Model") + val = len(model) > 0 and model[0] == 'Google Compute Engine' + if bios: + winreg.CloseKey(bios) + return val + except OSError: + return False + + def set_win_defaults(): # Enable the deps cache on windows. This makes a notable improvement # in performance at the cost of a ~200MB cache file. os.environ.setdefault("RBE_enable_deps_cache", "true") - # Reduce local resource fraction used to do local compile actions on - # windows, to try and prevent machine saturation. - os.environ.setdefault("RBE_local_resource_fraction", "0.05") + if is_win_ctop(): + # Reduce local resource fraction used to do local compile actions on + # windows, to try and prevent machine saturation. + os.environ.setdefault("RBE_local_resource_fraction", "0.05") def workspace_is_cog():