From 90a9eaf0426a721b6948e06d268c22ff00f66fc4 Mon Sep 17 00:00:00 2001 From: Takuto Ikuta Date: Tue, 30 May 2023 16:41:30 +0000 Subject: [PATCH] PRESUBMIT.py: remove `USE_PYTHON3 = True` presubmit now uses python3 only. Bug: 1207012 Change-Id: If8b701db42b22529faa91553061f1db52b83d4f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4570182 Auto-Submit: Takuto Ikuta Reviewed-by: Josip Sokcevic Commit-Queue: Josip Sokcevic --- PRESUBMIT.py | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index af0d07522..0d164419c 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -10,19 +10,10 @@ details on the presubmit API built into depot_tools. PRESUBMIT_VERSION = '2.0.0' -USE_PYTHON3 = True - import fnmatch import os import sys -# Whether to run the checks under Python2 or Python3. -# TODO: Uncomment this to run the checks under Python3, and change the tests -# in _CommonChecks in this file and the values and tests in -# //tests/PRESUBMIT.py as well to keep the test coverage of all three cases -# (true, false, and default/not specified). -# USE_PYTHON3 = False - # CIPD ensure manifest for checking CIPD client itself. CIPD_CLIENT_ENSURE_FILE_TEMPLATE = r''' # Full supported. @@ -128,9 +119,7 @@ def CheckUnitTestsOnCommit(input_api, output_api): output_api, 'tests', files_to_check=test_to_run_list, - files_to_skip=tests_to_skip_list, - run_on_python3=True, - run_on_python2=False) + files_to_skip=tests_to_skip_list) return input_api.RunTests(tests)