From 8edc960e9acbaedbff28e323e77a4129817266b3 Mon Sep 17 00:00:00 2001 From: Josip Sokcevic Date: Tue, 8 Mar 2022 17:38:40 +0000 Subject: [PATCH] Update gsutil to use gsutil version 4.68 We can't yet upgrade to version 5.x since it's only py3 compatbile and some builders still rely on running gsutil with py2. R=gavinmak@google.com Bug: 1184108 Change-Id: I002cc3625a2184ab42383b88a014c0631d1a33ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3508516 Reviewed-by: Gavin Mak Commit-Queue: Josip Sokcevic --- gsutil.py | 6 +-- gsutil.py.vpython3 | 19 +++++++++ gsutil.vpython | 104 --------------------------------------------- 3 files changed, 21 insertions(+), 108 deletions(-) create mode 100644 gsutil.py.vpython3 delete mode 100644 gsutil.vpython diff --git a/gsutil.py b/gsutil.py index 61aaafe1f..522ddb34b 100755 --- a/gsutil.py +++ b/gsutil.py @@ -34,7 +34,7 @@ DEFAULT_BIN_DIR = os.path.join(THIS_DIR, 'external_bin', 'gsutil') IS_WINDOWS = os.name == 'nt' -VERSION = '4.28' +VERSION = '4.68' class InvalidGsutilError(Exception): @@ -166,9 +166,7 @@ def run_gsutil(target, args, clean=False): assert sys.platform != 'cygwin' cmd = [ - 'vpython', - '-vpython-spec', os.path.join(THIS_DIR, 'gsutil.vpython'), - '--', + sys.executable, gsutil_bin ] + args_opt + args return subprocess.call(cmd, shell=IS_WINDOWS) diff --git a/gsutil.py.vpython3 b/gsutil.py.vpython3 new file mode 100644 index 000000000..a0e0a89e4 --- /dev/null +++ b/gsutil.py.vpython3 @@ -0,0 +1,19 @@ +# vpython VirtualEnv protobuf for "gsutil". +# +# See: +# https://chromium.googlesource.com/infra/luci/luci-go/+/HEAD/vpython/api/vpython/spec.proto +# +# This is a "vpython" VirtualEnv specification applied to invocations of "gsutil" +# by the bootstrap wrapper, "gsutil.py". It ensures that any Python distribution +# has the expected Python packages installed. +# +# This is specifically relevant on Google Compute Engine invocations of +# "gsutil", where a stock system-deployed file in "/etc/" explicitly specifies +# that the "google_compute_engine" and "boto" Python packages are available. + +python_version: "3.8" + +wheel: < + name: "infra/python/wheels/crcmod/${vpython_platform}" + version: "version:1.7.chromium.3" +> diff --git a/gsutil.vpython b/gsutil.vpython deleted file mode 100644 index c2e5ff7af..000000000 --- a/gsutil.vpython +++ /dev/null @@ -1,104 +0,0 @@ -# vpython VirtualEnv protobuf for "gsutil". -# -# See: -# https://chromium.googlesource.com/infra/luci/luci-go/+/HEAD/vpython/api/vpython/spec.proto -# -# This is a "vpython" VirtualEnv specification applied to invocations of "gsutil" -# by the bootstrap wrapper, "gsutil.py". It ensures that any Python distribution -# has the expected Python packages installed. -# -# This is specifically relevant on Google Compute Engine invocations of -# "gsutil", where a stock system-deployed file in "/etc/" explicitly specifies -# that the "google_compute_engine" and "boto" Python packages are available. - -python_version: "2.7" - -wheel < - name: "infra/python/wheels/google_compute_engine-py2_py3" - version: "version:2.6.2" -> -wheel < - name: "infra/python/wheels/boto-py2_py3" - version: "version:2.48.0" -> - -# "gsutil" on non-GCE can require PyOpenSSL, which, in turn, requires -# "cryptography". - -wheel: < - name: "infra/python/wheels/pyopenssl-py2_py3" - version: "version:17.2.0" -> - -## -# BEGIN "cryptography" dependencies. -## - -wheel: < - name: "infra/python/wheels/cryptography/${vpython_platform}" - version: "version:2.9.2.chromium.1" -> - -wheel: < - name: "infra/python/wheels/appdirs-py2_py3" - version: "version:1.4.3" -> - -wheel: < - name: "infra/python/wheels/enum34-py2" - version: "version:1.1.6" -> - -wheel: < - name: "infra/python/wheels/cffi/${vpython_platform}" - version: "version:1.14.5.chromium.7" -> - -wheel: < - name: "infra/python/wheels/idna-py2_py3" - version: "version:2.5" -> - -wheel: < - name: "infra/python/wheels/ipaddress-py2" - version: "version:1.0.18" -> - -wheel: < - name: "infra/python/wheels/packaging-py2_py3" - version: "version:16.8" -> - -wheel: < - name: "infra/python/wheels/pyasn1-py2_py3" - version: "version:0.2.3" -> - -wheel: < - name: "infra/python/wheels/pycparser-py2_py3" - version: "version:2.17" -> - -wheel: < - name: "infra/python/wheels/pyparsing-py2_py3" - version: "version:2.2.0" -> - -wheel: < - name: "infra/python/wheels/setuptools-py2_py3" - version: "version:34.3.2" -> - -wheel: < - name: "infra/python/wheels/six-py2_py3" - version: "version:1.10.0" -> - -## -# END "cryptography" dependencies. -## - -wheel: < - name: "infra/python/wheels/crcmod/${vpython_platform}" - version: "version:1.7.chromium.3" ->