From 89ccf4a8054906ad20ac112306e511246c90cb81 Mon Sep 17 00:00:00 2001 From: Bruce Dawson Date: Tue, 19 Apr 2022 21:36:46 +0000 Subject: [PATCH] Don't check header guards in cpplint.py Header guards are checked by CheckForIncludeGuards which has broader coverage than cpplint.py and should therefore be preferred. Having two include-guard checkers that cover different sets of files and use different tags to silence warnings is just confusing. Bug: 1309977 Change-Id: Ic0d1ad610cf9c34d6777d852da2e2e22b8686552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3587725 Reviewed-by: Peter Kasting Commit-Queue: Bruce Dawson --- presubmit_canned_checks.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index d1b436004..3d77a519d 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -40,10 +40,12 @@ OFF_BY_DEFAULT_LINT_FILTERS = [ # Justifications for each filter: # - build/c++11 : Include file and feature blocklists are # google3-specific +# - build/header_guard : Checked by CheckForIncludeGuards # - runtime/references : No longer banned by Google style guide # - whitespace/... : Most whitespace issues handled by clang-format OFF_UNLESS_MANUALLY_ENABLED_LINT_FILTERS = [ '-build/c++11', + '-build/header_guard', '-runtime/references', '-whitespace/braces', '-whitespace/comma',