Use an md5 hash of the tmpdir for the autoninja reclient pipe on windows
This is required because colons trigger an reproxy bug with named pipes currently and backslashes are technically invalid for named pipes https://learn.microsoft.com/en-us/windows/win32/ipc/pipe-names I considered replacing invalid characters with underscores but that may just push the problem down the road as it may create overlap between a directory with underscores and a directory with an invalid charachter that we replace. Since windows doesn't treat pipes as files, like linux treats sockets this naming is arbitrary, it only needs to be consistent and unique for a given output directory. So md5 is a good solution. Bug: b/271310759 Change-Id: I45409d7e9dc4cc1d0f056a3de8241ac877e682e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4300857 Commit-Queue: Ben Segall <bentekkie@google.com> Auto-Submit: Ben Segall <bentekkie@google.com> Reviewed-by: Takuto Ikuta <tikuta@chromium.org>changes/57/4300857/9
parent
f792c24879
commit
87fa610fe0
Loading…
Reference in New Issue