From 8404644cfd068ccc572a255370fae2b7ea30b00e Mon Sep 17 00:00:00 2001 From: Edward Lesmes Date: Tue, 9 Feb 2021 23:13:09 +0000 Subject: [PATCH] Ignore TBR and don't enforce OWNERS on commit Change-Id: Ic18cbdcbef99fcfc563a37df1e1727f1426233b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2685631 Reviewed-by: Jason Clinton Reviewed-by: Josip Sokcevic Commit-Queue: Edward Lesmes --- PRESUBMIT.py | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/PRESUBMIT.py b/PRESUBMIT.py index 7c68cab3f..83bad90ba 100644 --- a/PRESUBMIT.py +++ b/PRESUBMIT.py @@ -65,9 +65,6 @@ def CommonChecks(input_api, output_api, tests_to_skip_list, run_on_python3): input_api.SetTimeout(TEST_TIMEOUT_S) results = [] - results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) - results.extend(input_api.canned_checks.CheckOwnersFormat( - input_api, output_api)) results.extend(input_api.canned_checks.CheckJsonParses( input_api, output_api)) @@ -136,9 +133,15 @@ def CheckChangeOnUpload(input_api, output_api): r'^cipd_bootstrap_test\.py$', r'^gclient_smoketest\.py$', ] + results = [] + results.extend(input_api.canned_checks.CheckOwners( + input_api, output_api, allow_tbr=False)) + results.extend(input_api.canned_checks.CheckOwnersFormat( + input_api, output_api)) # TODO(ehmaldonado): Run Python 3 tests on upload once Python 3 is # bootstrapped on Linux and Mac. - return CommonChecks(input_api, output_api, tests_to_skip_list, False) + results.extend(CommonChecks(input_api, output_api, tests_to_skip_list, False)) + return results def CheckChangeOnCommit(input_api, output_api):