Add ability to specify that all issues are pivate in codereview.settings

TBR=maruel
Review URL: http://codereview.chromium.org/702001

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@40992 0039d316-1c4b-4281-b951-d872f2087c98

gcl.py

@@ -770,6 +770,9 @@ def UploadCL(change_info, args):
         subject = subject + "..."
       upload_arg.append("--message=" + subject)
 
+    if GetCodeReviewSetting("PRIVATE") == "True":
+      upload_arg.append("--private")
+
   # Change the current working directory before calling upload.py so that it
   # shows the correct base.
   previous_cwd = os.getcwd()

tests/gcl_unittest.py

@@ -279,6 +279,7 @@ class UploadCLUnittest(GclTestsBase):
     gcl.os.write(42, change_info.description)
     gcl.os.close(42)
     gcl.GetCodeReviewSetting('CC_LIST')
+    gcl.GetCodeReviewSetting('PRIVATE')
     gcl.os.getcwd().AndReturn('somewhere')
     gcl.os.chdir(change_info.GetLocalRoot())
     gcl.GenerateDiff(change_info.GetFileNames())
@@ -305,6 +306,7 @@ class UploadCLUnittest(GclTestsBase):
     gcl.os.write(42, change_info.description)
     gcl.os.close(42)
     gcl.GetCodeReviewSetting('CC_LIST')
+    gcl.GetCodeReviewSetting('PRIVATE')
     gcl.os.getcwd().AndReturn('somewhere')
     gcl.os.chdir(change_info.GetLocalRoot())
     gcl.GenerateDiff(change_info.GetFileNames())
@@ -331,6 +333,7 @@ class UploadCLUnittest(GclTestsBase):
     gcl.os.write(42, change_info.description)
     gcl.os.close(42)
     gcl.GetCodeReviewSetting('CC_LIST')
+    gcl.GetCodeReviewSetting('PRIVATE')
     gcl.os.getcwd().AndReturn('somewhere')
     gcl.os.chdir(change_info.GetLocalRoot())
     gcl.GenerateDiff(change_info.GetFileNames())