From 7aca9e8cb526e721b88958ddfeac492e667041c3 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Thu, 3 Dec 2009 19:06:09 +0000 Subject: [PATCH] Add a check so non-google employee don't send crash dumps. Add a warning message in case the check ever fail. Review URL: http://codereview.chromium.org/460044 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@33700 0039d316-1c4b-4281-b951-d872f2087c98 --- breakpad.py | 41 +++++++++++++++++++++++------------------ 1 file changed, 23 insertions(+), 18 deletions(-) diff --git a/breakpad.py b/breakpad.py index 8efe82a9a..003f9ad88 100644 --- a/breakpad.py +++ b/breakpad.py @@ -10,30 +10,35 @@ import atexit import getpass import urllib import traceback +import socket import sys def SendStack(stack, url='http://chromium-status.appspot.com/breakpad'): print 'Do you want to send a crash report [y/N]? ', - if sys.stdin.read(1).lower() == 'y': - try: - params = { - 'args': sys.argv, - 'stack': stack, - 'user': getpass.getuser(), - } - request = urllib.urlopen(url, urllib.urlencode(params)) - print request.read() - request.close() - except IOError: - print('There was a failure while trying to send the stack trace. Too bad.') - - -#@atexit.register -def CheckForException(): - if 'test' in sys.modules['__main__'].__file__: - # Probably a unit test. + if sys.stdin.read(1).lower() != 'y': return + print 'Sending crash report ...' + try: + params = { + 'args': sys.argv, + 'stack': stack, + 'user': getpass.getuser(), + } + request = urllib.urlopen(url, urllib.urlencode(params)) + print request.read() + request.close() + except IOError: + print('There was a failure while trying to send the stack trace. Too bad.') + + +def CheckForException(): last_tb = getattr(sys, 'last_traceback', None) if last_tb: SendStack(''.join(traceback.format_tb(last_tb))) + + +if (not 'test' in sys.modules['__main__'].__file__ and + socket.gethostname().endswith('.google.com')): + # Skip unit tests and we don't want anything from non-googler. + atexit.register(CheckForException)