From 798a9e3ecd94620b3f0b562b71de7d916660ed9c Mon Sep 17 00:00:00 2001 From: "stip@chromium.org" Date: Thu, 1 Oct 2015 01:58:45 +0000 Subject: [PATCH] Revert of Temporary fix for codereview cert issue. (patchset #3 id:2 of https://codereview.chromium.org/1376333002/ ) Reason for revert: Outage is now over Original issue's description: > Temporary fix for codereview cert issue. > > BUG=537763 > R=stip@chromium.org > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296959 TBR=tandrii@google.com,tandrii@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=537763 Review URL: https://codereview.chromium.org/1374223004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@296964 0039d316-1c4b-4281-b951-d872f2087c98 --- rietveld.py | 3 --- third_party/upload.py | 8 -------- 2 files changed, 11 deletions(-) diff --git a/rietveld.py b/rietveld.py index 5d83cc61b..1c569fc9b 100644 --- a/rietveld.py +++ b/rietveld.py @@ -579,9 +579,6 @@ class JwtOAuth2Rietveld(Rietveld): self.url = url.rstrip('/') bot_url = self.url - # TODO(tandrii): remove temp fix due to cert problem: crbug/537763 - if bot_url.endswith('codereview.chromium.org'): - bot_url = 'https://chromiumcodereview.appspot.com' if self.url.endswith('googleplex.com'): bot_url = self.url + '/bots' diff --git a/third_party/upload.py b/third_party/upload.py index 2f33b5abd..002a0d66a 100755 --- a/third_party/upload.py +++ b/third_party/upload.py @@ -2536,14 +2536,6 @@ def RealMain(argv, data=None): payload = urllib.urlencode(payload) rpc_server.Send("/" + issue + "/upload_complete/" + (patchset or ""), payload=payload) - # TODO(tandrii): remove temp fix due to cert problem: crbug/537763 - if ("codereview.chromium.org" in response_body and - (response_body.startswith("Issue created.") or - response_body.startswith("Issue updated."))): - print - print "NOTE: Due to certificate problems, try equivalent URL:" - print "https://chromiumcodereview.appspot.com/%s" % issue - print return issue, patchset