From 78cba52586d2b43518159754ce414571c56ad4c0 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Mon, 18 Oct 2010 13:32:05 +0000 Subject: [PATCH] gclient recurse fails if .gclient_entries doesn't exist. Prints a meaningful message instead of throwing an exception. TEST=none BUG=none Review URL: http://codereview.chromium.org/3828010 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@62920 0039d316-1c4b-4281-b951-d872f2087c98 --- gclient.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/gclient.py b/gclient.py index 6482efaa95..6b25cbec86 100644 --- a/gclient.py +++ b/gclient.py @@ -878,7 +878,13 @@ def CMDrecurse(parser, args): parser.add_option('-s', '--scm', action='append', default=[], help='choose scm types to operate upon') options, args = parser.parse_args(args) - root, entries = gclient_utils.GetGClientRootAndEntries() + root_and_entries = gclient_utils.GetGClientRootAndEntries() + if not root_and_entries: + print >> sys.stderr, ( + 'You need to run gclient sync at least once to use \'recurse\'.\n' + 'This is because .gclient_entries needs to exist and be up to date.') + return 1 + root, entries = root_and_entries scm_set = set() for scm in options.scm: scm_set.update(scm.split(','))