From 787e71ac8b5a316335375fbe3fcd76e6aebc3efe Mon Sep 17 00:00:00 2001 From: Jamie Madill Date: Fri, 9 Sep 2022 16:00:47 +0000 Subject: [PATCH] Fix code check in upload to google storage. The check was inverted, and was generating suprious error messages. Bug: None Change-Id: I139bb9e7d15e51fbec8c5703b26ed60e1ed1fab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3884910 Commit-Queue: Jamie Madill Commit-Queue: Josip Sokcevic Auto-Submit: Jamie Madill Reviewed-by: Josip Sokcevic --- upload_to_google_storage.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/upload_to_google_storage.py b/upload_to_google_storage.py index 2933cc2cfb..89b29eb53a 100755 --- a/upload_to_google_storage.py +++ b/upload_to_google_storage.py @@ -120,7 +120,7 @@ def _upload_worker( if os.stat(filename).st_mode & stat.S_IEXEC: code, _, err = gsutil.check_call_with_retries( 'setmeta', '-h', 'x-goog-meta-executable:1', file_url) - if not code: + if code != 0: ret_codes.put( (code, 'Encountered error on setting metadata on %s\n%s' %