From 77b74b5cf2503c6ab5ee36022771646283ca7369 Mon Sep 17 00:00:00 2001 From: "kjellander@chromium.org" Date: Sat, 29 Nov 2014 17:03:55 +0000 Subject: [PATCH] Revert of git_auto_svn.py: Rewrite http SVN URLs to https (patchset #3 id:40001 of https://codereview.chromium.org/745473003/) Reason for revert: This actually makes the Git mirrors unusable for git svn, since there's a mismatch between the svn remote URL and the URLs of the git-svn-id footers in each Git commit (which confuses scripts like git_cl.py and makes uploading and committing CLs impossible). Original issue's description: > git_auto_svn.py: Rewrite http SVN URLs to https > > BUG=435091 > TESTED=Ran the following: > git clone https://chromium.googlesource.com/external/webrtc > cd webrtc > git auto-svn > cat .git/config > Verified the URL was using http before this patch, and https after applying it. > > R=agable@chromium.org, mmoss@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=293041 TBR=agable@chromium.org,mmoss@chromium.org NOTREECHECKS=true NOTRY=true BUG=435091 Review URL: https://codereview.chromium.org/767913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@293148 0039d316-1c4b-4281-b951-d872f2087c98 --- git_auto_svn.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/git_auto_svn.py b/git_auto_svn.py index d3a966a21..4faa9a0d5 100755 --- a/git_auto_svn.py +++ b/git_auto_svn.py @@ -83,11 +83,6 @@ def main(argv): assert svn_repo is not None, 'Unable to find svn repo for %s' % match.group(1) print 'Found upstream svn repo %s and path %s' % (svn_repo, svn_path) - # TODO(kjellander): Remove when WebRTC has moved to Git (crbug.com/435091) - svn_url = urlparse.urlparse(svn_repo) - if svn_url.scheme == 'http' and svn_url.hostname.endswith('googlecode.com'): - svn_repo = svn_repo.replace('http://', 'https://') - set_config('svn-remote.svn.url', svn_repo) set_config('svn-remote.svn.fetch', '%s:refs/remotes/%s' % (svn_path, upstream))