From 6e7ddb698ba00641bd5672b0e646cbe098b5498b Mon Sep 17 00:00:00 2001 From: Aaron Gable Date: Wed, 27 May 2020 22:23:29 +0000 Subject: [PATCH] Remove agable from depot_tools OWNERS and TODOs Change-Id: I0667af4562208a111ab3673f3fca6aab655f5f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2218962 Auto-Submit: Aaron Gable Reviewed-by: Anthony Polito Commit-Queue: Anthony Polito --- OWNERS | 1 - gclient.py | 5 ----- gclient_utils.py | 1 - git_cl.py | 2 +- presubmit_canned_checks.py | 1 - presubmit_support.py | 6 +++--- 6 files changed, 4 insertions(+), 12 deletions(-) diff --git a/OWNERS b/OWNERS index 97bd9ef01b..3a2ad6becc 100644 --- a/OWNERS +++ b/OWNERS @@ -1,6 +1,5 @@ set noparent -agable@chromium.org apolito@google.com dpranke@chromium.org ehmaldonado@chromium.org diff --git a/gclient.py b/gclient.py index b2f15a7721..5acbfae1d0 100755 --- a/gclient.py +++ b/gclient.py @@ -2698,11 +2698,6 @@ def CMDsync(parser, args): parser.add_option('--lock_timeout', type='int', default=5000, help='GIT ONLY - Deadline (in seconds) to wait for git ' 'cache lock to become available. Default is %default.') - # TODO(agable): Remove these when the oldest CrOS release milestone is M56. - parser.add_option('-t', '--transitive', action='store_true', - help='DEPRECATED: This is a no-op.') - parser.add_option('-m', '--manually_grab_svn_rev', action='store_true', - help='DEPRECATED: This is a no-op.') parser.add_option('--no-rebase-patch-ref', action='store_false', dest='rebase_patch_ref', default=True, help='Bypass rebase of the patch ref after checkout.') diff --git a/gclient_utils.py b/gclient_utils.py index 498b27a203..8267b9662b 100644 --- a/gclient_utils.py +++ b/gclient_utils.py @@ -425,7 +425,6 @@ class Annotated(Wrapper): # Continue lockless. obj[0] += out while True: - # TODO(agable): find both of these with a single pass. cr_loc = obj[0].find(b'\r') lf_loc = obj[0].find(b'\n') if cr_loc == lf_loc == -1: diff --git a/git_cl.py b/git_cl.py index 4d999ed281..612d4f94d4 100755 --- a/git_cl.py +++ b/git_cl.py @@ -2300,7 +2300,7 @@ class Changelist(object): if self.GetIssue() and (reviewers or cc): # GetIssue() is not set in case of non-squash uploads according to tests. - # TODO(agable): non-squash uploads in git cl should be removed. + # TODO(crbug.com/751901): non-squash uploads in git cl should be removed. gerrit_util.AddReviewers( self._GetGerritHost(), self._GerritChangeIdentifier(), diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index ef1984e8b7..595971db7d 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -1612,7 +1612,6 @@ def CheckLucicfgGenOutput(input_api, output_api, entry_script): output_api.PresubmitError) ] -# TODO(agable): Add this to PanProjectChecks. def CheckJsonParses(input_api, output_api): """Verifies that all JSON files at least parse as valid JSON.""" import json diff --git a/presubmit_support.py b/presubmit_support.py index ffcfe9f3fd..f58530e0d3 100755 --- a/presubmit_support.py +++ b/presubmit_support.py @@ -1119,12 +1119,12 @@ class Change(object): def TBRsFromDescription(self): """Returns all TBR reviewers listed in the commit description.""" tags = [r.strip() for r in self.tags.get('TBR', '').split(',') if r.strip()] - # TODO(agable): Remove support for 'Tbr:' when TBRs are programmatically - # determined by self-CR+1s. + # TODO(crbug.com/839208): Remove support for 'Tbr:' when TBRs are + # programmatically determined by self-CR+1s. footers = self.GitFootersFromDescription().get('Tbr', []) return sorted(set(tags + footers)) - # TODO(agable): Delete these once we're sure they're unused. + # TODO(crbug.com/753425): Delete these once we're sure they're unused. @property def BUG(self): return ','.join(self.BugsFromDescription())