From 6c7723e796982b710705848641164cbbb8583f60 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Tue, 12 Apr 2011 19:04:55 +0000 Subject: [PATCH] Add --verbose flag when input_api.verbose is set. It could result in failed tests so I'll revert if it ever becomes problematic. It ran fine with my limited testing. R=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/6813114 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@81279 0039d316-1c4b-4281-b951-d872f2087c98 --- presubmit_canned_checks.py | 1 + tests/presubmit_unittest.py | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/presubmit_canned_checks.py b/presubmit_canned_checks.py index f75d297ba..7a8d98dca 100644 --- a/presubmit_canned_checks.py +++ b/presubmit_canned_checks.py @@ -456,6 +456,7 @@ def RunUnitTests(input_api, output_api, unit_tests): cmd.append(unit_test) if input_api.verbose: print('Running %s' % unit_test) + cmd.append('--verbose') try: if input_api.verbose: input_api.subprocess.check_call(cmd, cwd=input_api.PresubmitLocalPath()) diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py index ca43acbec..c0e7916ab 100755 --- a/tests/presubmit_unittest.py +++ b/tests/presubmit_unittest.py @@ -2015,8 +2015,8 @@ mac|success|blew input_api.PresubmitLocalPath().AndReturn(self.fake_root_dir) input_api.PresubmitLocalPath().AndReturn(self.fake_root_dir) input_api.subprocess.check_call( - ['allo'], cwd=self.fake_root_dir) - cmd = ['bar.py'] + ['allo', '--verbose'], cwd=self.fake_root_dir) + cmd = ['bar.py', '--verbose'] if input_api.platform == 'win32': cmd.insert(0, input_api.python_executable) input_api.subprocess.check_call( @@ -2044,7 +2044,7 @@ mac|success|blew input_api.os_listdir(path).AndReturn(['.', '..', 'a', 'b', 'c']) input_api.os_path.isfile = lambda x: not x.endswith('.') input_api.subprocess.check_call( - [presubmit.os.path.join('random_directory', 'b')], + [presubmit.os.path.join('random_directory', 'b'), '--verbose'], cwd=self.fake_root_dir) self.mox.ReplayAll()