From 657aaf250de3ea3d3130d6f2bf0c248dfca562c7 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Fri, 22 May 2009 01:04:15 +0000 Subject: [PATCH] When the svn diff output (on Windows) is sent as a single POST and some of the files have attribute changes, the server responds with a list of files where the files with attribute changes have backslashes (as they do in the svn diff output). Fix this in the client. A server-side fix might also be nice; where does the server-side code live? BUG=none TEST=none Patch contributed by Joi. Review URL: http://codereview.chromium.org/112050 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@16688 0039d316-1c4b-4281-b951-d872f2087c98 --- upload.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/upload.py b/upload.py index 3140908eb..bd29b2f7d 100755 --- a/upload.py +++ b/upload.py @@ -1346,6 +1346,12 @@ def RealMain(argv, data=None): msg = lines[0] patchset = lines[1].strip() patches = [x.split(" ", 1) for x in lines[2:]] + for patch_pair in patches: + # On Windows if a file has property changes its filename uses '\' + # instead of '/'. Perhaps this change should be made (also) on the + # server when it is decoding the patch file sent by the client, but + # we do it here as well to be safe. + patch_pair[1] = patch_pair[1].replace('\\', '/') else: msg = response_body else: