|
|
|
@ -2700,16 +2700,16 @@ class CannedChecksUnittest(PresubmitTestsBase):
|
|
|
|
|
|
|
|
|
|
def testCannedCheckOwners_NoIssueNoFiles(self):
|
|
|
|
|
self.AssertOwnersWorks(issue=None,
|
|
|
|
|
expected_output="OWNERS check failed: this change has no Rietveld "
|
|
|
|
|
"issue number, so we can't check it for approvals.\n")
|
|
|
|
|
expected_output="OWNERS check failed: this CL has no Gerrit "
|
|
|
|
|
"change number, so we can't check it for approvals.\n")
|
|
|
|
|
self.AssertOwnersWorks(issue=None, is_committing=False,
|
|
|
|
|
expected_output="")
|
|
|
|
|
|
|
|
|
|
def testCannedCheckOwners_NoIssue(self):
|
|
|
|
|
self.AssertOwnersWorks(issue=None,
|
|
|
|
|
uncovered_files=set(['foo']),
|
|
|
|
|
expected_output="OWNERS check failed: this change has no Rietveld "
|
|
|
|
|
"issue number, so we can't check it for approvals.\n")
|
|
|
|
|
expected_output="OWNERS check failed: this CL has no Gerrit "
|
|
|
|
|
"change number, so we can't check it for approvals.\n")
|
|
|
|
|
self.AssertOwnersWorks(issue=None,
|
|
|
|
|
is_committing=False,
|
|
|
|
|
uncovered_files=set(['foo']),
|
|
|
|
@ -2720,8 +2720,8 @@ class CannedChecksUnittest(PresubmitTestsBase):
|
|
|
|
|
self.AssertOwnersWorks(issue=None,
|
|
|
|
|
reviewers=set(['jane@example.com']),
|
|
|
|
|
manually_specified_reviewers=['jane@example.com'],
|
|
|
|
|
expected_output="OWNERS check failed: this change has no Rietveld "
|
|
|
|
|
"issue number, so we can't check it for approvals.\n")
|
|
|
|
|
expected_output="OWNERS check failed: this CL has no Gerrit "
|
|
|
|
|
"change number, so we can't check it for approvals.\n")
|
|
|
|
|
self.AssertOwnersWorks(issue=None,
|
|
|
|
|
reviewers=set(['jane@example.com']),
|
|
|
|
|
manually_specified_reviewers=['jane@example.com'],
|
|
|
|
@ -2732,8 +2732,8 @@ class CannedChecksUnittest(PresubmitTestsBase):
|
|
|
|
|
self.AssertOwnersWorks(issue=None,
|
|
|
|
|
reviewers=set(['jane']),
|
|
|
|
|
manually_specified_reviewers=['jane@example.com'],
|
|
|
|
|
expected_output="OWNERS check failed: this change has no Rietveld "
|
|
|
|
|
"issue number, so we can't check it for approvals.\n")
|
|
|
|
|
expected_output="OWNERS check failed: this CL has no Gerrit "
|
|
|
|
|
"change number, so we can't check it for approvals.\n")
|
|
|
|
|
self.AssertOwnersWorks(issue=None,
|
|
|
|
|
uncovered_files=set(['foo']),
|
|
|
|
|
manually_specified_reviewers=['jane'],
|
|
|
|
|