From 5b9f90e5926632f0892e7ca6e51c916c7a1fb5f0 Mon Sep 17 00:00:00 2001 From: "viettrungluu@chromium.org" Date: Wed, 5 Mar 2014 03:28:24 +0000 Subject: [PATCH] Make toolchain2013.py work properly if there's a space in the temp path. TBR=maruel@chromium.org R=scottmg@chromium.org Review URL: https://codereview.chromium.org/184103027 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@254932 0039d316-1c4b-4281-b951-d872f2087c98 --- win_toolchain/toolchain2013.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/win_toolchain/toolchain2013.py b/win_toolchain/toolchain2013.py index 0cda59039..201e6c7b4 100755 --- a/win_toolchain/toolchain2013.py +++ b/win_toolchain/toolchain2013.py @@ -196,10 +196,11 @@ def DownloadSDK8(): 'Running sdksetup.exe to download Win8 SDK (may request elevation)...\n') count = 0 while count < 5: - rc = os.system(target_path + ' /quiet ' - '/features OptionId.WindowsDesktopDebuggers ' - 'OptionId.WindowsDesktopSoftwareDevelopmentKit ' - '/layout ' + standalone_path) + rc = subprocess.call([target_path, + '/quiet', + '/features', 'OptionId.WindowsDesktopDebuggers', + 'OptionId.WindowsDesktopSoftwareDevelopmentKit', + '/layout', standalone_path]) if rc == 0: return standalone_path count += 1