[git_cl] Add _base_url property

Makes __init__ a bit cleaner, and planning to make _shortname a
property also next, since it can be derived from _remote_url

Bug: b/351071334
Change-Id: I12f4363723172a9cdaba37f6beb8fa37bbf09d72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/5718639
Commit-Queue: Allen Li <ayatane@chromium.org>
Reviewed-by: Yiwei Zhang <yiwzhang@google.com>
changes/39/5718639/2
Allen Li 11 months ago committed by LUCI CQ
parent 14ddf6e8ba
commit 5a723500c0

@ -13,6 +13,7 @@ import collections
import datetime
import enum
import fnmatch
import functools
import httplib2
import itertools
import json
@ -3720,12 +3721,16 @@ class GitAuthConfigChanger(object):
self.mode: GitConfigMode = mode
self._shortname: str = host_shortname
parts: urllib.parse.SplitResult = urllib.parse.urlsplit(remote_url)
# Base URL looks like https://chromium.googlesource.com/
self._base_url: str = parts._replace(path='/', query='',
fragment='').geturl()
self._remote_url: str = remote_url
self._set_config_func: Callable[..., str] = set_config_func
@functools.cached_property
def _base_url(self) -> str:
# Base URL looks like https://chromium.googlesource.com/
parts: urllib.parse.SplitResult = urllib.parse.urlsplit(
self._remote_url)
return parts._replace(path='/', query='', fragment='').geturl()
@classmethod
def new_from_env(cls) -> 'GitAuthConfigChanger':
"""Create a GitAuthConfigChanger by inferring from env."""

Loading…
Cancel
Save