From 59622a5b31a444b4107b876f4c9b276c2295a5a0 Mon Sep 17 00:00:00 2001
From: Takuto Ikuta <tikuta@chromium.org>
Date: Thu, 11 Jun 2020 05:36:31 +0000
Subject: [PATCH] use CREATE_NEW_PROCESS_GROUP to invoke ninjalog_uploader

This is necessary to make ninjalog_uploader_wrapper.py exit without
waitinng finish of ninjalog_uploader.py in windows.

Bug: 992282
Change-Id: I69d11074bcbe5d0958468a9c8ec8391b0741a839
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/2237269
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
---
 ninjalog_uploader_wrapper.py | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/ninjalog_uploader_wrapper.py b/ninjalog_uploader_wrapper.py
index ae45d25158..44efa79fe6 100755
--- a/ninjalog_uploader_wrapper.py
+++ b/ninjalog_uploader_wrapper.py
@@ -5,8 +5,10 @@
 
 from __future__ import print_function
 
-import os
 import json
+import os
+import platform
+import subprocess
 import sys
 
 import ninjalog_uploader
@@ -110,9 +112,13 @@ def main():
 
   # Run upload script without wait.
   devnull = open(os.devnull, "w")
+  creationnflags = 0
+  if platform.system() == 'Windows':
+    creationnflags = subprocess.CREATE_NEW_PROCESS_GROUP
   subprocess2.Popen(['vpython', UPLOADER] + sys.argv[1:],
                     stdout=devnull,
-                    stderr=devnull)
+                    stderr=devnull,
+                    creationflags=creationnflags)
 
 
 if __name__ == '__main__':