From 58f5357e9202be7729c72843a10ebc48d3f609cb Mon Sep 17 00:00:00 2001 From: Garrett Beaty Date: Thu, 5 Dec 2024 17:18:36 +0000 Subject: [PATCH] Remove the build_internal_script_slave config. The gclient config refers to a repo that is no longer used and includes non-inclusive language. Bug: 40712760 Change-Id: Id7faec4beefdc4387cd8860910e43cbdcac3625a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6070412 Commit-Queue: Garrett Beaty Reviewed-by: Yiwei Zhang --- recipes/README.recipes.md | 2 +- recipes/recipe_modules/gclient/config.py | 13 ------------- recipes/recipe_modules/gclient/examples/full.py | 1 - 3 files changed, 1 insertion(+), 15 deletions(-) diff --git a/recipes/README.recipes.md b/recipes/README.recipes.md index 12587634b..12f4b0a86 100644 --- a/recipes/README.recipes.md +++ b/recipes/README.recipes.md @@ -1108,7 +1108,7 @@ Raises: [DEPS](/recipes/recipe_modules/gclient/examples/full.py#7): [gclient](#recipe_modules-gclient), [recipe\_engine/assertions][recipe_engine/recipe_modules/assertions], [recipe\_engine/buildbucket][recipe_engine/recipe_modules/buildbucket], [recipe\_engine/context][recipe_engine/recipe_modules/context], [recipe\_engine/file][recipe_engine/recipe_modules/file], [recipe\_engine/path][recipe_engine/recipe_modules/path], [recipe\_engine/properties][recipe_engine/recipe_modules/properties], [recipe\_engine/step][recipe_engine/recipe_modules/step] -— **def [RunSteps](/recipes/recipe_modules/gclient/examples/full.py#73)(api):** +— **def [RunSteps](/recipes/recipe_modules/gclient/examples/full.py#72)(api):** ### *recipes* / [gclient:tests/diff\_deps](/recipes/recipe_modules/gclient/tests/diff_deps.py) [DEPS](/recipes/recipe_modules/gclient/tests/diff_deps.py#10): [gclient](#recipe_modules-gclient), [recipe\_engine/assertions][recipe_engine/recipe_modules/assertions], [recipe\_engine/buildbucket][recipe_engine/recipe_modules/buildbucket], [recipe\_engine/path][recipe_engine/recipe_modules/path], [recipe\_engine/platform][recipe_engine/recipe_modules/platform], [recipe\_engine/properties][recipe_engine/recipe_modules/properties], [recipe\_engine/raw\_io][recipe_engine/recipe_modules/raw_io] diff --git a/recipes/recipe_modules/gclient/config.py b/recipes/recipe_modules/gclient/config.py index f70da1bdc..6490070d2 100644 --- a/recipes/recipe_modules/gclient/config.py +++ b/recipes/recipe_modules/gclient/config.py @@ -192,19 +192,6 @@ def build_internal(c): build(c) c.got_revision_mapping['build'] = 'got_build_revision' -@config_ctx() -def build_internal_scripts_slave(c): - s = c.solutions.add() - s.name = 'build_internal/scripts/slave' - s.url = ('https://chrome-internal.googlesource.com/' - 'chrome/tools/build_limited/scripts/slave.git') - c.got_revision_mapping['build_internal/scripts/slave'] = 'got_revision' - # We do not use 'includes' here, because we want build_internal to be the - # first solution in the list as run_presubmit computes upstream revision - # from the first solution. - build(c) - c.got_revision_mapping['build'] = 'got_build_revision' - @config_ctx() def pdfium(c): soln = c.solutions.add() diff --git a/recipes/recipe_modules/gclient/examples/full.py b/recipes/recipe_modules/gclient/examples/full.py index 71e5f9402..9203262d9 100644 --- a/recipes/recipe_modules/gclient/examples/full.py +++ b/recipes/recipe_modules/gclient/examples/full.py @@ -20,7 +20,6 @@ TEST_CONFIGS = [ 'android', 'boringssl', 'build_internal', - 'build_internal_scripts_slave', 'catapult', 'celab', 'crashpad',