From 5828285134b5b150ee118f3fc0ad26464e08c3fc Mon Sep 17 00:00:00 2001 From: Philipp Wollermann Date: Thu, 9 Nov 2023 10:52:26 +0000 Subject: [PATCH] Deprecate autosiso.bat and autosiso. These are no longer needed, since autoninja now delegates to either Ninja or Siso based on the value of the "use_siso" GN arg. Bug: b/293657720 Change-Id: I612640c6f902b2a1336f856fdf3f723214114ff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4997648 Reviewed-by: Bruce Dawson Commit-Queue: Philipp Wollermann Reviewed-by: Fumitoshi Ukai Reviewed-by: Junji Watanabe --- autosiso | 8 ++++++-- autosiso.bat | 14 +++++++------- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/autosiso b/autosiso index 7abd9f7296..8cd528f6c5 100755 --- a/autosiso +++ b/autosiso @@ -4,5 +4,9 @@ # Use of this source code is governed by a BSD-style license that can be # found in the LICENSE file. -base_dir=$(dirname "$0") -PYTHONDONTWRITEBYTECODE=1 exec python3 "$base_dir/autosiso.py" "$@" +echo "Error: 'autosiso' is deprecated and will be removed soon." >&2 +echo "" >&2 +echo "You can just run 'autoninja' instead, which will delegate either to Ninja" >&2 +echo "or to Siso based on the value of the 'use_siso' GN arg." >&2 + +exit 1 diff --git a/autosiso.bat b/autosiso.bat index a4a6e36985..4b5f4cf41c 100644 --- a/autosiso.bat +++ b/autosiso.bat @@ -4,11 +4,11 @@ :: found in the LICENSE file. setlocal -:: Ensure that "depot_tools" is somewhere in PATH so this tool can be used -:: standalone, but allow other PATH manipulations to take priority. -set PATH=%PATH%;%~dp0 +echo Error: 'autosiso' is deprecated and will be removed soon. +echo. +echo You can just run 'autoninja' instead, which will delegate either to Ninja +echo or to Siso based on the value of the 'use_siso' GN arg. -:: Defer control. -:: Add double quotes to the arguments to preserve the special '^' character. -:: See autosiso.py for more information. -python3 "%~dp0\autosiso.py" "%*" +:: Return an error code of 1 so that if a developer types: +:: "autosiso chrome && chrome" then the second part won't accidentally be run. +cmd /c exit 1