From 57dfc366b76154719ccddf31d27ffc9a10242b9c Mon Sep 17 00:00:00 2001 From: Joey Scarr Date: Mon, 2 Jun 2025 21:55:46 -0700 Subject: [PATCH] Revert "[git_auth] Configure common -review hosts also" This reverts commit 39e269dabf62217a87c03be180a49005add1a2b2. Reason for revert: Breaks git cl upload via SSO Bug: 421831933 Original change's description: > [git_auth] Configure common -review hosts also > > Seems like ChromeOS workflows with repo force these URLs. While the > repo instructions technically tell users to set this up separately, > config them here too so I don't get bug reports. > > Bug: 421831933 > Change-Id: Ie33c678de3a6d2dadd6663ad6e0e97e9086d6129 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6614517 > Reviewed-by: Gavin Mak > Commit-Queue: Allen Li Bug: 421831933 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I76a981ff50bc1b9e18c82223e23d891b89917924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6615841 Auto-Submit: Joey Scarr Owners-Override: Joey Scarr Commit-Queue: Joey Scarr Reviewed-by: Fumitoshi Ukai Bot-Commit: Rubber Stamper --- git_auth.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/git_auth.py b/git_auth.py index 58f4967fd..411dbb2bb 100644 --- a/git_auth.py +++ b/git_auth.py @@ -561,11 +561,7 @@ class ConfigWizard(object): 'beto-core.googlesource.com', 'boringssl.googlesource.com', 'chromium.googlesource.com', - # repo upload (for ChromeOS) adds -review, - # even if Git is configured without the -review - 'chromium-review.googlesource.com', 'chrome-internal.googlesource.com', - 'chrome-internal-review.googlesource.com', 'dawn.googlesource.com', 'pdfium.googlesource.com', 'quiche.googlesource.com',