From 4c55b355580f0c0f0daebfb086b2ccf11d90f605 Mon Sep 17 00:00:00 2001 From: Tamer Tas Date: Thu, 22 Aug 2019 15:30:35 +0000 Subject: [PATCH] [devtools] create devtools-frontend gclient config devtools-frontend is missing from gclient configs, causing the breakage: https://ci.chromium.org/p/devtools-frontend/builders/ci/DevTools%20Linux/b8904421330390983280 This CL creates the devtools-frontend configuration R=tandrii@chromium.org TBR=machenbach@chromium.org CC=yangguo@chromium.org Bug: chromium:995657 Change-Id: I8e5ffce16f2b8f69931a71cd67a709427d1f42ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1765591 Reviewed-by: Tamer Tas Auto-Submit: Tamer Tas Commit-Queue: Tamer Tas --- recipes/README.recipes.md | 2 +- recipes/recipe_modules/gclient/config.py | 7 +++++++ recipes/recipe_modules/gclient/examples/full.py | 1 + 3 files changed, 9 insertions(+), 1 deletion(-) diff --git a/recipes/README.recipes.md b/recipes/README.recipes.md index a1e5a3f7d0..3141c8caf5 100644 --- a/recipes/README.recipes.md +++ b/recipes/README.recipes.md @@ -981,7 +981,7 @@ Raises: [DEPS](/recipes/recipe_modules/gclient/examples/full.py#5): [gclient](#recipe_modules-gclient), [recipe\_engine/context][recipe_engine/recipe_modules/context], [recipe\_engine/path][recipe_engine/recipe_modules/path], [recipe\_engine/properties][recipe_engine/recipe_modules/properties], [recipe\_engine/step][recipe_engine/recipe_modules/step] -— **def [RunSteps](/recipes/recipe_modules/gclient/examples/full.py#52)(api):** +— **def [RunSteps](/recipes/recipe_modules/gclient/examples/full.py#53)(api):** ### *recipes* / [gclient:tests/patch\_project](/recipes/recipe_modules/gclient/tests/patch_project.py) [DEPS](/recipes/recipe_modules/gclient/tests/patch_project.py#9): [gclient](#recipe_modules-gclient), [recipe\_engine/buildbucket][recipe_engine/recipe_modules/buildbucket], [recipe\_engine/properties][recipe_engine/recipe_modules/properties] diff --git a/recipes/recipe_modules/gclient/config.py b/recipes/recipe_modules/gclient/config.py index af89fe696f..284c321466 100644 --- a/recipes/recipe_modules/gclient/config.py +++ b/recipes/recipe_modules/gclient/config.py @@ -442,3 +442,10 @@ def openscreen(c): s.name = 'openscreen' s.url = 'https://chromium.googlesource.com/openscreen' c.got_revision_mapping['openscreen'] = 'got_revision' + +@config_ctx() +def devtools(c): + s = c.solutions.add() + s.name = 'devtools' + s.url = 'https://chromium.googlesource.com/devtools/devtools-frontend.git' + c.got_revision_mapping['devtools'] = 'got_revision' diff --git a/recipes/recipe_modules/gclient/examples/full.py b/recipes/recipe_modules/gclient/examples/full.py index f832be3f22..be06dc1580 100644 --- a/recipes/recipe_modules/gclient/examples/full.py +++ b/recipes/recipe_modules/gclient/examples/full.py @@ -37,6 +37,7 @@ TEST_CONFIGS = [ 'luci_py', 'master_deps', 'nacl', + 'devtools', 'openscreen', 'pdfium', 'recipes_py',