From 4b6a833b54c65d8a87efa82066a3e99e9e535cea Mon Sep 17 00:00:00 2001 From: Takuto Ikuta Date: Thu, 2 Mar 2023 07:35:47 +0000 Subject: [PATCH] Revert "disable log collection temporarily" This reverts commit 7bf7e06945109cad2881d8a55022bdbfb2587721. Reason for revert: Issue is fixed in https://crrev.com/c/4297356 Original change's description: > disable log collection temporarily > > This is for b/270907050#comment2. > > Bug: b/270907050 > Change-Id: I4e816d38c1a0f379662533e278ab77cc46a8664a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4290688 > Commit-Queue: Dirk Pranke > Auto-Submit: Takuto Ikuta > Reviewed-by: Dirk Pranke > Reviewed-by: Junji Watanabe Bug: b/270907050 Change-Id: I63a4e9a872708d57e8a782b59e43a06c884a92ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4297698 Commit-Queue: Junji Watanabe Bot-Commit: Rubber Stamper Reviewed-by: Fumitoshi Ukai Reviewed-by: Dirk Pranke Reviewed-by: Junji Watanabe --- ninjalog_uploader.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/ninjalog_uploader.py b/ninjalog_uploader.py index 957e6cdf57..f803390554 100755 --- a/ninjalog_uploader.py +++ b/ninjalog_uploader.py @@ -197,10 +197,6 @@ def main(): # Disable logging. logging.disable(logging.CRITICAL) - if True: # This is for unreachable code lint warning. - # TODO(b/270907050): disable log collection temporarily. - return 0 - if not IsGoogler(): return 0