From 443d9135cc33f3156d5fe25ebec33f9adffbab65 Mon Sep 17 00:00:00 2001 From: dpapad Date: Thu, 5 May 2022 00:17:30 +0000 Subject: [PATCH] Include TypeScript .ts files in DEFAULT_FILES_TO_CHECK. These were previously erroneously skipped resulting in missing violations. Fixed: 1322170 Change-Id: I62d27f60bc1761f1f8809c6a7db2ca5f4e05e120 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3626289 Reviewed-by: Bruce Dawson Auto-Submit: Demetrios Papadopoulos Reviewed-by: Robbie Iannucci Commit-Queue: Demetrios Papadopoulos --- presubmit_support.py | 3 ++- tests/presubmit_unittest.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/presubmit_support.py b/presubmit_support.py index 5ff2a236e..fb3cb51ed 100755 --- a/presubmit_support.py +++ b/presubmit_support.py @@ -559,7 +559,8 @@ class InputApi(object): r'.+\.c$', r'.+\.cc$', r'.+\.cpp$', r'.+\.h$', r'.+\.m$', r'.+\.mm$', r'.+\.inl$', r'.+\.asm$', r'.+\.hxx$', r'.+\.hpp$', r'.+\.s$', r'.+\.S$', # Scripts - r'.+\.js$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', r'.+\.pm$', + r'.+\.js$', r'.+\.ts$', r'.+\.py$', r'.+\.sh$', r'.+\.rb$', r'.+\.pl$', + r'.+\.pm$', # Other r'.+\.java$', r'.+\.mk$', r'.+\.am$', r'.+\.css$', r'.+\.mojom$', r'.+\.fidl$' diff --git a/tests/presubmit_unittest.py b/tests/presubmit_unittest.py index f2ebb5099..0fd02fb7c 100755 --- a/tests/presubmit_unittest.py +++ b/tests/presubmit_unittest.py @@ -1409,7 +1409,7 @@ class InputApiUnittest(PresubmitTestsBase): def testDefaultOverrides(self): input_api = presubmit.InputApi( self.fake_change, './PRESUBMIT.py', False, None, False) - self.assertEqual(len(input_api.DEFAULT_FILES_TO_CHECK), 24) + self.assertEqual(len(input_api.DEFAULT_FILES_TO_CHECK), 25) self.assertEqual(len(input_api.DEFAULT_FILES_TO_SKIP), 12) input_api.DEFAULT_FILES_TO_CHECK = (r'.+\.c$',)