From 3ea2614b3ef1e38258f3b88dc0d9ebacb53fb660 Mon Sep 17 00:00:00 2001 From: "tandrii@chromium.org" Date: Thu, 28 Apr 2016 12:29:10 +0000 Subject: [PATCH] Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #1 id:1 of https://codereview.chromium.org/1926663002/ ) Reason for revert: Schedules fine, but property not set: https://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/14295/ reverting first, then investigating. Original issue's description: > git cl try: don't skip presubmit builders, but set dry_run property. > > R=machenbach@chromium.org,sergiyb@chromium.org > BUG=601128,594127,591030 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300265 TBR=machenbach@chromium.org,sergiyb@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601128,594127,591030 Review-Url: https://codereview.chromium.org/1929483004 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300274 0039d316-1c4b-4281-b951-d872f2087c98 --- git_cl.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/git_cl.py b/git_cl.py index 7bd7c8ec1..0acb9cd59 100755 --- a/git_cl.py +++ b/git_cl.py @@ -337,8 +337,6 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category): 'rietveld': rietveld_url, }, } - if 'presubmit' not in builder.lower(): - parameters['properties']['dry_run'] = 'true' if tests: parameters['properties']['testfilter'] = tests if properties: @@ -4318,7 +4316,8 @@ def CMDtry(parser, args): for master, builders in cq_masters.iteritems(): for builder in builders: # Skip presubmit builders, because these will fail without LGTM. - masters.setdefault(master, {})[builder] = ['defaulttests'] + if 'presubmit' not in builder.lower(): + masters.setdefault(master, {})[builder] = ['defaulttests'] if masters: return masters