diff --git a/git_cl/git_cl.py b/git_cl/git_cl.py index 5bbab8018..80329cbff 100644 --- a/git_cl/git_cl.py +++ b/git_cl/git_cl.py @@ -710,17 +710,20 @@ def UserEditedLog(starting_text): fileobj.write(starting_text) fileobj.close() - ret = subprocess.call(editor + ' ' + filename, shell=True) - if ret != 0: + result = None + try: + subprocess.check_call(['env', editor, filename], shell=True) + fileobj = open(filename) + result = fileobj.read() + fileobj.close() + finally: os.remove(filename) - return - fileobj = open(filename) - text = fileobj.read() - fileobj.close() - os.remove(filename) + if not result: + return + stripcomment_re = re.compile(r'^#.*$', re.MULTILINE) - return stripcomment_re.sub('', text).strip() + return stripcomment_re.sub('', result).strip() def ConvertToInteger(inputval):