From 3b07526aec5572513374e26191e83d367a6e1f7b Mon Sep 17 00:00:00 2001 From: Jesse McKenna Date: Tue, 9 Jul 2019 00:07:49 +0000 Subject: [PATCH] Update autoninja's psutil from v5.2.2 to v5.6.2 This incorporates a fix to psutil's calculation of the number of processors on Windows systems with more than 64 cores. Windows systems with more than 64 logical processors divide the processors into groups, with most applications using only one group, i.e. a portion of the actual processing power available. Prior to v5.4.4, psutil only counted the number of processors in the first processor group. This resulted in only partial utilization of high- processing-power systems. For example, on the 72-core P920, this change has the following effect: Before: > autoninja -C out\nogoma chrome "c:\src\depot_tools\ninja.exe" -C out\nogoma base -j 38 After: > autoninja -C out\nogoma chrome "c:\src\depot_tools\ninja.exe" -C out\nogoma base -j 74 Using this new version of psutil doubles the number of processors used for building Chrome on the P920 (when not using goma). A similar bug exists in ninja.exe, so using autoninja will be particularly important after this fix for users of the P920 and other systems with >64 cores. More fixes will be needed elsewhere for similar bugs - see crbug.com/980967 for general progress. Bug: 980270 Change-Id: I8de61a72cf95acf28ef1bcef1b0057b7b1225832 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1686081 Commit-Queue: Jesse McKenna Reviewed-by: Bruce Dawson Reviewed-by: Robbie Iannucci --- autoninja.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autoninja.py b/autoninja.py index a7beac5f0..b83087612 100755 --- a/autoninja.py +++ b/autoninja.py @@ -14,7 +14,7 @@ on non-goma builds. # [VPYTHON:BEGIN] # wheel: < # name: "infra/python/wheels/psutil/${vpython_platform}" -# version: "version:5.2.2" +# version: "version:5.6.2" # > # [VPYTHON:END]