From 3a5cc4081382ea47793f166b3d71b19e35ad83f7 Mon Sep 17 00:00:00 2001 From: Junji Watanabe Date: Mon, 22 May 2023 04:59:44 +0000 Subject: [PATCH] [autosiso] Do not double quote arguments on Windows. The double quotations are necessary to preserve "^" for Ninja's single file compilation. But Siso doesn't support this syntax for now. Bug: b/270653823 Change-Id: I9c775ad295119dad3b1ba5aebdccce59127232c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/4551121 Auto-Submit: Junji Watanabe Commit-Queue: Junji Watanabe Reviewed-by: Fumitoshi Ukai --- autosiso.bat | 2 +- autosiso.py | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/autosiso.bat b/autosiso.bat index 5cb658150..f32bedfc1 100644 --- a/autosiso.bat +++ b/autosiso.bat @@ -9,4 +9,4 @@ setlocal set PATH=%PATH%;%~dp0 :: Defer control. -python3 "%~dp0\autosiso.py" "%*" +python3 "%~dp0\autosiso.py" %* diff --git a/autosiso.py b/autosiso.py index c052c84d3..751a32f5f 100755 --- a/autosiso.py +++ b/autosiso.py @@ -32,6 +32,12 @@ def _use_remoteexec(argv): def main(argv): + # TODO(b/283714114): support single file compile with '^'. + # The arguments need to be passed as a double quoted string on Windows. + # + # pylint: disable=line-too-long + # See also https://source.chromium.org/chromium/chromium/tools/depot_tools/+/main:autoninja.py;l=33-42;drc=eb2866e6541607f63cdc50038379886c77f17506 + if not _use_remoteexec(argv): print( "`use_remoteexec=true` is not detected.\n"