From 39e269dabf62217a87c03be180a49005add1a2b2 Mon Sep 17 00:00:00 2001 From: Allen Li Date: Mon, 2 Jun 2025 15:18:53 -0700 Subject: [PATCH] [git_auth] Configure common -review hosts also Seems like ChromeOS workflows with repo force these URLs. While the repo instructions technically tell users to set this up separately, config them here too so I don't get bug reports. Bug: 421831933 Change-Id: Ie33c678de3a6d2dadd6663ad6e0e97e9086d6129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/6614517 Reviewed-by: Gavin Mak Commit-Queue: Allen Li --- git_auth.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/git_auth.py b/git_auth.py index 411dbb2bbd..58f4967fd2 100644 --- a/git_auth.py +++ b/git_auth.py @@ -561,7 +561,11 @@ class ConfigWizard(object): 'beto-core.googlesource.com', 'boringssl.googlesource.com', 'chromium.googlesource.com', + # repo upload (for ChromeOS) adds -review, + # even if Git is configured without the -review + 'chromium-review.googlesource.com', 'chrome-internal.googlesource.com', + 'chrome-internal-review.googlesource.com', 'dawn.googlesource.com', 'pdfium.googlesource.com', 'quiche.googlesource.com',