Enable strict coverage for all modules

Bug: chromium:693058
Change-Id: I6e00f73141722dc47f8da16e21dadd1d4e26a14f
Reviewed-on: https://chromium-review.googlesource.com/475911
Commit-Queue: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>

recipes/recipe_modules/gclient/__init__.py

@@ -8,7 +8,3 @@ DEPS = [
   'recipe_engine/step',
   'tryserver',
 ]
-
-
-# TODO(phajdan.jr): provide coverage (http://crbug.com/693058).
-DISABLE_STRICT_COVERAGE = True

recipes/recipe_modules/gclient/tests/patch_project.py

@@ -0,0 +1,39 @@
+# Copyright 2017 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from recipe_engine import post_process
+from recipe_engine import recipe_api
+
+
+DEPS = [
+  'gclient',
+  'recipe_engine/properties',
+]
+
+
+PROPERTIES = {
+  'patch_project': recipe_api.Property(),
+}
+
+
+def RunSteps(api, patch_project):
+  api.gclient.set_config('chromium')
+
+  patch_root = api.gclient.calculate_patch_root(patch_project)
+
+  api.gclient.set_patch_project_revision(patch_project)
+
+
+def GenTests(api):
+  yield (
+      api.test('chromium') +
+      api.properties(patch_project='chromium') +
+      api.post_process(post_process.DropExpectation)
+  )
+
+  yield (
+      api.test('v8') +
+      api.properties(patch_project='v8') +
+      api.post_process(post_process.DropExpectation)
+  )

recipes/recipe_modules/git/__init__.py

@@ -7,7 +7,3 @@ DEPS = [
   'recipe_engine/raw_io',
   'recipe_engine/step',
 ]
-
-
-# TODO(phajdan.jr): provide coverage (http://crbug.com/693058).
-DISABLE_STRICT_COVERAGE = True

recipes/recipe_modules/git_cl/__init__.py

@@ -2,7 +2,3 @@ DEPS = [
   'recipe_engine/raw_io',
   'recipe_engine/step',
 ]
-
-
-# TODO(phajdan.jr): provide coverage (http://crbug.com/693058).
-DISABLE_STRICT_COVERAGE = True

recipes/recipe_modules/infra_paths/__init__.py

@@ -2,6 +2,3 @@ DEPS = [
   'recipe_engine/path',
   'recipe_engine/properties',
 ]
-
-# TODO(phajdan): provide coverage (http://crbug.com/693058).
-DISABLE_STRICT_COVERAGE = True

recipes/recipe_modules/infra_paths/example.expected/basic.json

@@ -4,6 +4,7 @@
     "name": "show cache path",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@result@base_paths: {'start_dir': ('/', 'b', 'FakeTestingCWD'), 'cache': ('/', 'b', 'c'), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('cache', 'git')@@@",
       "@@@STEP_LOG_END@result@@@"
     ]
   },

recipes/recipe_modules/infra_paths/example.expected/paths_buildbot_linux.json

@@ -4,6 +4,7 @@
     "name": "show cache path",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@result@base_paths: {'depot_tools': ('depot_tools',), 'build_internal': ('build_internal',), 'cache': ('build', 'slave', 'cache'), 'goma_cache': ('build', 'slave', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'build': ('build',), 'git_cache': ('build', 'slave', 'cache_dir'), 'root': (), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
       "@@@STEP_LOG_END@result@@@"
     ]
   },

recipes/recipe_modules/infra_paths/example.expected/paths_buildbot_mac.json

@@ -4,6 +4,7 @@
     "name": "show cache path",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@result@base_paths: {'depot_tools': ('depot_tools',), 'build_internal': ('build_internal',), 'cache': ('build', 'slave', 'cache'), 'goma_cache': ('build', 'slave', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'build': ('build',), 'git_cache': ('build', 'slave', 'cache_dir'), 'root': (), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
       "@@@STEP_LOG_END@result@@@"
     ]
   },

recipes/recipe_modules/infra_paths/example.expected/paths_buildbot_win.json

@@ -4,6 +4,7 @@
     "name": "show cache path",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@result@base_paths: {'depot_tools': ('depot_tools',), 'build_internal': ('build_internal',), 'cache': ('build', 'slave', 'cache'), 'goma_cache': ('build', 'slave', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'build': ('build',), 'git_cache': ('build', 'slave', 'cache_dir'), 'root': (), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
       "@@@STEP_LOG_END@result@@@"
     ]
   },

recipes/recipe_modules/infra_paths/example.expected/paths_generic_linux.json

@@ -4,6 +4,7 @@
     "name": "show cache path",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'builder'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git'), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
       "@@@STEP_LOG_END@result@@@"
     ]
   },

recipes/recipe_modules/infra_paths/example.expected/paths_generic_mac.json

@@ -4,6 +4,7 @@
     "name": "show cache path",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'builder'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git'), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
       "@@@STEP_LOG_END@result@@@"
     ]
   },

recipes/recipe_modules/infra_paths/example.expected/paths_generic_win.json

@@ -4,6 +4,7 @@
     "name": "show cache path",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'builder'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git'), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
       "@@@STEP_LOG_END@result@@@"
     ]
   },

recipes/recipe_modules/infra_paths/example.expected/paths_kitchen_linux.json

@@ -4,6 +4,7 @@
     "name": "show cache path",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'b'), 'goma_deps_cache': ('/', 'b', 'c', 'goma_deps_cache'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git_cache'), 'root': ('/', 'b', 'FakeTestingCWD'), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
       "@@@STEP_LOG_END@result@@@"
     ]
   },

recipes/recipe_modules/infra_paths/example.expected/paths_kitchen_mac.json

@@ -4,6 +4,7 @@
     "name": "show cache path",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'b'), 'goma_deps_cache': ('/', 'b', 'c', 'goma_deps_cache'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git_cache'), 'root': ('/', 'b', 'FakeTestingCWD'), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
       "@@@STEP_LOG_END@result@@@"
     ]
   },

recipes/recipe_modules/infra_paths/example.expected/paths_kitchen_win.json

@@ -4,6 +4,7 @@
     "name": "show cache path",
     "~followup_annotations": [
       "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'b'), 'goma_deps_cache': ('/', 'b', 'c', 'goma_deps_cache'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma_cache'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git_cache'), 'root': ('/', 'b', 'FakeTestingCWD'), 'tmp_base': ('/',)}@@@",
+      "@@@STEP_LOG_LINE@result@default_git_cache_dir: Path('git_cache')@@@",
       "@@@STEP_LOG_END@result@@@"
     ]
   },

recipes/recipe_modules/infra_paths/example.py

@@ -17,6 +17,7 @@ def RunSteps(api):
   api.step('show cache path', [])
   api.step.active_result.presentation.logs['result'] = [
     'base_paths: %r' % (api.path.c.base_paths,),
+    'default_git_cache_dir: %r' % (api.infra_paths.default_git_cache_dir,),
   ]
 
 

recipes/recipe_modules/rietveld/__init__.py

@@ -4,7 +4,3 @@ DEPS = [
   'recipe_engine/python',
   'recipe_engine/step',
 ]
-
-
-# TODO(phajdan.jr): provide coverage (http://crbug.com/693058).
-DISABLE_STRICT_COVERAGE = True

recipes/recipe_modules/rietveld/example.expected/no_auth.json

@@ -0,0 +1,27 @@
+[
+  {
+    "cmd": [
+      "python",
+      "-u",
+      "RECIPE_PACKAGE_REPO[depot_tools]/apply_issue.py",
+      "-r",
+      "[START_DIR]/foo/bar",
+      "-i",
+      "1",
+      "-p",
+      "1",
+      "-s",
+      "http://review_tool.url",
+      "--no-auth"
+    ],
+    "name": "apply_issue",
+    "~followup_annotations": [
+      "@@@STEP_LINK@Applied issue 1@http://review_tool.url/1@@@"
+    ]
+  },
+  {
+    "name": "$result",
+    "recipe_result": null,
+    "status_code": 0
+  }
+]

recipes/recipe_modules/rietveld/example.py

@@ -12,7 +12,8 @@ DEPS = [
 
 def RunSteps(api):
   api.path['checkout'] = api.path['start_dir']
-  api.rietveld.apply_issue('foo', 'bar', authentication='oauth2')
+  api.rietveld.apply_issue(
+      'foo', 'bar', authentication=api.properties.get('authentication'))
   api.rietveld.calculate_issue_root({'project': ['']})
 
 
@@ -21,10 +22,17 @@ def GenTests(api):
       issue=1,
       patchset=1,
       rietveld='http://review_tool.url',
+      authentication='oauth2',
+  )
+  yield api.test('no_auth') + api.properties(
+      issue=1,
+      patchset=1,
+      rietveld='http://review_tool.url',
   )
   yield api.test('buildbot') + api.properties(
       path_config='buildbot',
       issue=1,
       patchset=1,
       rietveld='http://review_tool.url',
+      authentication='oauth2',
   )

recipes/recipe_modules/tryserver/__init__.py

@@ -14,7 +14,3 @@ DEPS = [
   'rietveld',
   'recipe_engine/step',
 ]
-
-
-# TODO(phajdan): provide coverage (http://crbug.com/693058).
-DISABLE_STRICT_COVERAGE = True