Regression: Editor Linux Fix for gcl.

Editor doesn't come up due to Shell=True

BUG=none
TEST=linux and win works
Review URL: http://codereview.chromium.org/6679023

git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@77913 0039d316-1c4b-4281-b951-d872f2087c98

gcl.py

@@ -1063,10 +1063,9 @@ def CMDchange(args):
   os.write(handle, text)
   os.close(handle)
 
-  result = None
   try:
     if not silent:
-      subprocess.check_call(['env', GetEditor(), filename], shell=True)
+      subprocess.check_call(['env', GetEditor(), filename])
     result = gclient_utils.FileRead(filename, 'r')
   finally:
     os.remove(filename)

git_cl/git_cl.py

@@ -710,9 +710,8 @@ def UserEditedLog(starting_text):
   fileobj.write(starting_text)
   fileobj.close()
 
-  result = None
   try:
-    subprocess.check_call(['env', editor, filename], shell=True)
+    subprocess.check_call(['env', editor, filename])
     fileobj = open(filename)
     result = fileobj.read()
     fileobj.close()