From 383ace4b35b87d706ae204a064884bc0ce779c8a Mon Sep 17 00:00:00 2001 From: Yuke Liao Date: Fri, 14 Jul 2017 13:46:25 -0700 Subject: [PATCH] Fix git-crrev-parse on Mac. Previously, running git crrev-parse {crrev_number} on Mac doesn't produce any meaningful output, and the reason is that parameter substitutions resulted in extra back slashes ('\'): ref="refs/heads/master" remote_ref="${ref/refs\/heads/refs\/remotes\/origin}" expected: remote_ref="refs/remotes/origin/master" actual: remote_ref="refs\/remotes\/origin/master" This CL fixes the issue by removing the extra back slashes. Bug: Change-Id: I1ee1b4702f09c96fb65518ee1465d0de927e95cc Reviewed-on: https://chromium-review.googlesource.com/572052 Reviewed-by: Dirk Pranke Commit-Queue: Yuke Liao --- git-crrev-parse | 1 + 1 file changed, 1 insertion(+) diff --git a/git-crrev-parse b/git-crrev-parse index 3046998a75..5296573f2b 100755 --- a/git-crrev-parse +++ b/git-crrev-parse @@ -39,6 +39,7 @@ while [ -n "$1" ]; do fi remote_ref="${ref/refs\/heads/refs\/remotes\/origin}" remote_ref="${remote_ref/refs\/branch-heads/refs\/remotes\/branch-heads}" + remote_ref="${remote_ref//\\}" num="${commit_pos#*@\{\#}" num="${num%\}}" if [ -z "$ref" -o -z "$num" ]; then