From 35d1a84d76ebea0687c9311092ab3e3b77ec6e78 Mon Sep 17 00:00:00 2001 From: "jamesr@chromium.org" Date: Fri, 27 Jul 2012 00:20:43 +0000 Subject: [PATCH] Remove autogeneration of TEST= and automated check Review URL: https://chromiumcodereview.appspot.com/10827059 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@148672 0039d316-1c4b-4281-b951-d872f2087c98 --- git_cl.py | 2 -- tests/git_cl_test.py | 18 +++++++++--------- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/git_cl.py b/git_cl.py index fa7007bd2..143ad2854 100755 --- a/git_cl.py +++ b/git_cl.py @@ -683,8 +683,6 @@ class ChangeDescription(object): content += '\nR=' + self.reviewers if '\nBUG=' not in self.description: content += '\nBUG=' - if '\nTEST=' not in self.description: - content += '\nTEST=' content = content.rstrip('\n') + '\n' content = gclient_utils.RunEditor(content, True) if not content: diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py index 5ae17f914..0c3736e23 100755 --- a/tests/git_cl_test.py +++ b/tests/git_cl_test.py @@ -253,14 +253,14 @@ class TestGitCl(TestCase): def test_no_reviewer(self): self._run_reviewer_test( [], - 'desc\n\nBUG=\nTEST=\n', - '# Blah blah comment.\ndesc\n\nBUG=\nTEST=\n', - 'desc\n\nBUG=\nTEST=\n', + 'desc\n\nBUG=\n', + '# Blah blah comment.\ndesc\n\nBUG=\n', + 'desc\n\nBUG=\n', []) def test_reviewers_cmd_line(self): # Reviewer is passed as-is - description = 'desc\n\nR=foo@example.com\nBUG=\nTEST=\n' + description = 'desc\n\nR=foo@example.com\nBUG=\n' self._run_reviewer_test( ['-r' 'foo@example.com'], description, @@ -274,7 +274,7 @@ class TestGitCl(TestCase): description = 'Foo Bar\nTBR=reviewer@example.com\n' self._run_reviewer_test( ['-r' 'foo@example.com'], - 'desc\n\nR=foo@example.com\nBUG=\nTEST=\n', + 'desc\n\nR=foo@example.com\nBUG=\n', description.strip('\n'), description, ['--reviewers', 'reviewer@example.com']) @@ -285,7 +285,7 @@ class TestGitCl(TestCase): 'Foo Bar\nTBR=reviewer@example.com\nBUG=\nR=another@example.com\n') self._run_reviewer_test( [], - 'desc\n\nBUG=\nTEST=\n', + 'desc\n\nBUG=\n', description, description, ['--reviewers', 'reviewer@example.com,another@example.com']) @@ -295,7 +295,7 @@ class TestGitCl(TestCase): description = 'Foo Bar\nR=reviewer@example.com\n' self._run_reviewer_test( ['--send-mail'], - 'desc\n\nBUG=\nTEST=\n', + 'desc\n\nBUG=\n', description.strip('\n'), description, ['--reviewers', 'reviewer@example.com', '--send_mail']) @@ -390,13 +390,13 @@ class TestGitCl(TestCase): def test_gerrit_no_reviewer(self): self._run_gerrit_reviewer_test( [], - 'desc\n\nBUG=\nTEST=\n', + 'desc\n\nBUG=\n', []) def test_gerrit_reviewers_cmd_line(self): self._run_gerrit_reviewer_test( ['-r', 'foo@example.com'], - 'desc\n\nBUG=\nTEST=\n', + 'desc\n\nBUG=\n', ['foo@example.com']) def test_gerrit_reviewer_multiple(self):