From 2e36aadcceb739f015f51da114625b63c298320b Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Sun, 25 Sep 2011 00:50:49 +0000 Subject: [PATCH] Add distinction for review made by himself. I heard some people like to review their changes themselves. :) TBR=dpranke@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8045007 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@102670 0039d316-1c4b-4281-b951-d872f2087c98 --- my_reviews.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/my_reviews.py b/my_reviews.py index 1d2377278..47db1da21 100755 --- a/my_reviews.py +++ b/my_reviews.py @@ -67,12 +67,13 @@ class Stats(object): self.multiple_lgtms = 0 self.drive_by = 0 self.not_requested = 0 + self.self_review = 0 self.percent_done = 0. self.percent_lgtm = 0. self.percent_drive_by = 0. self.percent_not_requested = 0. - self.days = None + self.days = 0 self.review_per_day = 0. self.review_done_per_day = 0. @@ -168,7 +169,11 @@ def print_issue(issue, reviewer, stats): """Process an issue and prints stats about it.""" stats.total += 1 _process_issue(issue) - if any(msg['sender'] == reviewer for msg in issue['messages']): + if issue['owner_email'] == reviewer: + stats.self_review += 1 + latency = '' + reviewed = '' + elif any(msg['sender'] == reviewer for msg in issue['messages']): reviewed = _process_issue_lgtms(issue, reviewer, stats) latency = _process_issue_latency(issue, reviewer, stats) else: @@ -215,8 +220,9 @@ def print_reviews(reviewer, created_after, created_before, instance_url): stats.finalize(first_day, last_day) print >> sys.stderr, ( - '%s reviewed %d issues out of %d (%1.1f%%).' % - (reviewer, stats.actually_reviewed, stats.total, stats.percent_done)) + '%s reviewed %d issues out of %d (%1.1f%%). %d were self-review.' % + (reviewer, stats.actually_reviewed, stats.total, stats.percent_done, + stats.self_review)) print >> sys.stderr, ( '%4.1f review request/day during %3d days (%4.1f r/d done).' % ( stats.review_per_day, stats.days, stats.review_done_per_day))