From 2c376aa21bef061e6529c1459eb161ce31140d7c Mon Sep 17 00:00:00 2001 From: Andrii Shyshkalov Date: Fri, 9 Jun 2017 15:39:37 +0200 Subject: [PATCH] git cl: Fix incorrect notify parameter when setting TBR. Follow up on https://chromium-review.googlesource.com/c/527325/ R=agable@chromium.org,rmistry@chromium.org Bug: chromium:729967 Bug: skia:6744 Change-Id: I7443298797a7c95c8ca01624e3cbf08c95e04855 Reviewed-on: https://chromium-review.googlesource.com/529246 Reviewed-by: Ravi Mistry Commit-Queue: Andrii Shyshkalov --- git_cl.py | 3 ++- tests/git_cl_test.py | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/git_cl.py b/git_cl.py index 5266b5fe9..7ccf8e096 100755 --- a/git_cl.py +++ b/git_cl.py @@ -3102,7 +3102,8 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase): print('Adding self-LGTM (Code-Review +1) because of TBRs.') gerrit_util.SetReview( self._GetGerritHost(), self.GetIssue(), - labels={'Code-Review': 1}, notify=bool(options.send_mail)) + labels={'Code-Review': 1}, + notify='ALL' if options.send_mail else 'NONE') return 0 diff --git a/tests/git_cl_test.py b/tests/git_cl_test.py index afb4dcd20..b7b4804fa 100755 --- a/tests/git_cl_test.py +++ b/tests/git_cl_test.py @@ -1581,7 +1581,8 @@ class TestGitCl(TestCase): if tbr: calls += [ (('SetReview', 'chromium-review.googlesource.com', - 123456 if squash else None, {'Code-Review': 1}, notify), ''), + 123456 if squash else None, {'Code-Review': 1}, + 'ALL' if notify else 'NONE'), ''), ] calls += cls._git_post_upload_calls() return calls