From 289dedd36b188d07a25c5342d9ec06be50dfa670 Mon Sep 17 00:00:00 2001 From: Josip Sokcevic Date: Thu, 27 Jan 2022 23:40:33 +0000 Subject: [PATCH] Remove unused arguments from bot_update recipe gclient removed syntax validation flag in 2020: https://crrev.com/c/2083589, so this can safely be removed. R=aravindvasudev@google.com, gavinmak@google.com Recipe-Nontrivial-Roll: chrome_release Recipe-Nontrivial-Roll: build_limited Recipe-Nontrivial-Roll: build Change-Id: I2aced6cdb01d571ca361cc57e7c8715c9ca40552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/3419278 Reviewed-by: Gavin Mak Commit-Queue: Josip Sokcevic --- recipes/README.recipes.md | 13 +++++-------- recipes/recipe_modules/bot_update/api.py | 6 ------ .../examples/full.expected/add_blamelists.json | 3 +-- .../add_blamelists_bot_update_failure.json | 3 +-- .../bot_update/examples/full.expected/basic.json | 3 +-- .../full.expected/basic_with_branch_heads.json | 3 +-- .../examples/full.expected/bot_update_failure.json | 3 +-- .../bot_update/examples/full.expected/clobber.json | 3 +-- .../deprecated_got_revision_mapping.json | 3 +-- .../full.expected/gerrit_no_rebase_patch_ref.json | 3 +-- .../examples/full.expected/gerrit_no_reset.json | 3 +-- .../input_commit_with_id_without_repo.json | 3 +-- .../examples/full.expected/multiple_patch_refs.json | 3 +-- .../full.expected/no_apply_patch_on_gclient.json | 3 +-- .../examples/full.expected/no_cp_checkout_HEAD.json | 3 +-- .../full.expected/no_cp_checkout_a_branch_head.json | 3 +-- .../no_cp_checkout_a_specific_commit.json | 3 +-- .../examples/full.expected/no_cp_checkout_main.json | 3 +-- .../examples/full.expected/origin_main.json | 3 +-- .../bot_update/examples/full.expected/refs.json | 3 +-- .../full.expected/reset_root_solution_revision.json | 3 +-- .../resolve_chromium_fixed_version.json | 3 +-- .../revision_fallback_chain_set_output_commit.json | 3 +-- .../full.expected/revision_specifying_ref.json | 3 +-- .../examples/full.expected/tryjob_fail.json | 3 +-- .../examples/full.expected/tryjob_fail_patch.json | 3 +-- .../full.expected/tryjob_fail_patch_download.json | 3 +-- .../examples/full.expected/tryjob_gerrit_angle.json | 3 +-- .../full.expected/tryjob_gerrit_branch_heads.json | 3 +-- .../full.expected/tryjob_gerrit_feature_branch.json | 3 +-- .../tryjob_gerrit_v8_feature_branch.json | 3 +-- .../full.expected/tryjob_gerrit_webrtc.json | 3 +-- .../examples/full.expected/tryjob_v8.json | 3 +-- .../full.expected/tryjob_v8_head_by_default.json | 3 +-- .../examples/full.expected/with_experiments.json | 1 - .../examples/full.expected/with_tags.json | 3 +-- recipes/recipe_modules/bot_update/examples/full.py | 1 - recipes/recipe_modules/gclient/config.py | 6 ------ recipes/recipe_modules/gclient/examples/full.py | 1 - 39 files changed, 38 insertions(+), 89 deletions(-) diff --git a/recipes/README.recipes.md b/recipes/README.recipes.md index 0164af2a2..3335fbcde 100644 --- a/recipes/README.recipes.md +++ b/recipes/README.recipes.md @@ -58,12 +58,12 @@ Recipe module to ensure a checkout is consistent on a bot. Wrapper for easy calling of bot_update. -— **def [deapply\_patch](/recipes/recipe_modules/bot_update/api.py#522)(self, bot_update_step):** +— **def [deapply\_patch](/recipes/recipe_modules/bot_update/api.py#516)(self, bot_update_step):** Deapplies a patch, taking care of DEPS and solution revisions properly. -— **def [ensure\_checkout](/recipes/recipe_modules/bot_update/api.py#81)(self, gclient_config=None, suffix=None, patch=True, update_presentation=True, patch_root=None, with_branch_heads=False, with_tags=False, no_fetch_tags=False, refs=None, clobber=False, root_solution_revision=None, gerrit_no_reset=False, gerrit_no_rebase_patch_ref=False, assert_one_gerrit_change=True, disable_syntax_validation=False, patch_refs=None, ignore_input_commit=False, add_blamelists=False, set_output_commit=False, step_test_data=None, enforce_fetch=False, \*\*kwargs):** +— **def [ensure\_checkout](/recipes/recipe_modules/bot_update/api.py#81)(self, gclient_config=None, suffix=None, patch=True, update_presentation=True, patch_root=None, with_branch_heads=False, with_tags=False, no_fetch_tags=False, refs=None, clobber=False, root_solution_revision=None, gerrit_no_reset=False, gerrit_no_rebase_patch_ref=False, assert_one_gerrit_change=True, patch_refs=None, ignore_input_commit=False, add_blamelists=False, set_output_commit=False, step_test_data=None, enforce_fetch=False, \*\*kwargs):** Args: * gclient_config: The gclient configuration to use when running bot_update. @@ -72,9 +72,6 @@ Args: fetch any tags referenced from the references being fetched. When a repo has many references, it can become a performance bottleneck, so avoid tags if the checkout will not need them present. - * disable_syntax_validation: (legacy) Disables syntax validation for DEPS. - Needed as migration paths for recipes dealing with older revisions, - such as bisect. * ignore_input_commit: if True, ignore api.buildbucket.gitiles_commit. Exists for historical reasons. Please do not use. * add_blamelists: if True, add blamelist pins for all of the repos that had @@ -95,7 +92,7 @@ Args: bot_update module ONLY supports one change. Users may specify a change via tryserver.set_change() and explicitly set this flag False. -— **def [get\_project\_revision\_properties](/recipes/recipe_modules/bot_update/api.py#499)(self, project_name, gclient_config=None):** +— **def [get\_project\_revision\_properties](/recipes/recipe_modules/bot_update/api.py#493)(self, project_name, gclient_config=None):** Returns all property names used for storing the checked-out revision of a given project. @@ -111,7 +108,7 @@ Returns (list of str): All properties that'll hold the checked-out revision   **@property**
— **def [last\_returned\_properties](/recipes/recipe_modules/bot_update/api.py#49)(self):** -— **def [resolve\_fixed\_revision](/recipes/recipe_modules/bot_update/api.py#450)(self, bot_update_json, name):** +— **def [resolve\_fixed\_revision](/recipes/recipe_modules/bot_update/api.py#444)(self, bot_update_json, name):** Sets a fixed revision for a single dependency using project revision properties. @@ -1013,7 +1010,7 @@ PYTHON_VERSION_COMPATIBILITY: PY2+3 PYTHON_VERSION_COMPATIBILITY: PY2+3 -— **def [RunSteps](/recipes/recipe_modules/gclient/examples/full.py#67)(api):** +— **def [RunSteps](/recipes/recipe_modules/gclient/examples/full.py#66)(api):** ### *recipes* / [gclient:tests/diff\_deps](/recipes/recipe_modules/gclient/tests/diff_deps.py) [DEPS](/recipes/recipe_modules/gclient/tests/diff_deps.py#9): [gclient](#recipe_modules-gclient), [recipe\_engine/assertions][recipe_engine/recipe_modules/assertions], [recipe\_engine/buildbucket][recipe_engine/recipe_modules/buildbucket], [recipe\_engine/path][recipe_engine/recipe_modules/path], [recipe\_engine/platform][recipe_engine/recipe_modules/platform], [recipe\_engine/properties][recipe_engine/recipe_modules/properties], [recipe\_engine/raw\_io][recipe_engine/recipe_modules/raw_io] diff --git a/recipes/recipe_modules/bot_update/api.py b/recipes/recipe_modules/bot_update/api.py index 4d331f345..06758a00c 100644 --- a/recipes/recipe_modules/bot_update/api.py +++ b/recipes/recipe_modules/bot_update/api.py @@ -93,7 +93,6 @@ class BotUpdateApi(recipe_api.RecipeApi): gerrit_no_reset=False, gerrit_no_rebase_patch_ref=False, assert_one_gerrit_change=True, - disable_syntax_validation=False, patch_refs=None, ignore_input_commit=False, add_blamelists=False, @@ -109,9 +108,6 @@ class BotUpdateApi(recipe_api.RecipeApi): fetch any tags referenced from the references being fetched. When a repo has many references, it can become a performance bottleneck, so avoid tags if the checkout will not need them present. - * disable_syntax_validation: (legacy) Disables syntax validation for DEPS. - Needed as migration paths for recipes dealing with older revisions, - such as bisect. * ignore_input_commit: if True, ignore api.buildbucket.gitiles_commit. Exists for historical reasons. Please do not use. * add_blamelists: if True, add blamelist pins for all of the repos that had @@ -284,8 +280,6 @@ class BotUpdateApi(recipe_api.RecipeApi): cmd.append('--no_fetch_tags') if gerrit_no_rebase_patch_ref: cmd.append('--gerrit_no_rebase_patch_ref') - if disable_syntax_validation or cfg.disable_syntax_validation: - cmd.append('--disable-syntax-validation') if self.m.properties.get('bot_update_experiments'): cmd.append('--experiments=%s' % ','.join(self.m.properties['bot_update_experiments'])) diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/add_blamelists.json b/recipes/recipe_modules/bot_update/examples/full.expected/add_blamelists.json index d2d76a9e0..f57db3ce5 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/add_blamelists.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/add_blamelists.json @@ -19,8 +19,7 @@ "--revision", "src/v8@HEAD", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/add_blamelists_bot_update_failure.json b/recipes/recipe_modules/bot_update/examples/full.expected/add_blamelists_bot_update_failure.json index c1116d4ff..0df13a6da 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/add_blamelists_bot_update_failure.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/add_blamelists_bot_update_failure.json @@ -19,8 +19,7 @@ "--revision", "src/v8@HEAD", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/basic.json b/recipes/recipe_modules/bot_update/examples/full.expected/basic.json index 5e94c47c2..c03f56d96 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/basic.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/basic.json @@ -17,8 +17,7 @@ "--revision", "src@2d72510e447ab60a9728aeea2362d8be2cbd7789", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/basic_with_branch_heads.json b/recipes/recipe_modules/bot_update/examples/full.expected/basic_with_branch_heads.json index 79aa0f5ae..0eaf1cca9 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/basic_with_branch_heads.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/basic_with_branch_heads.json @@ -18,8 +18,7 @@ "src@2d72510e447ab60a9728aeea2362d8be2cbd7789", "--refs", "refs/heads/main", - "--with_branch_heads", - "--disable-syntax-validation" + "--with_branch_heads" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/bot_update_failure.json b/recipes/recipe_modules/bot_update/examples/full.expected/bot_update_failure.json index c83728ab9..3d799aa61 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/bot_update_failure.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/bot_update_failure.json @@ -17,8 +17,7 @@ "--revision", "src@2d72510e447ab60a9728aeea2362d8be2cbd7789", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/clobber.json b/recipes/recipe_modules/bot_update/examples/full.expected/clobber.json index 8abd6323b..77d0f65af 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/clobber.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/clobber.json @@ -16,8 +16,7 @@ "/path/to/tmp/json", "--revision", "src@HEAD", - "--clobber", - "--disable-syntax-validation" + "--clobber" ], "env": { "DEPOT_TOOLS_COLLECT_METRICS": "0", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/deprecated_got_revision_mapping.json b/recipes/recipe_modules/bot_update/examples/full.expected/deprecated_got_revision_mapping.json index 534ea26ee..8a81ceb49 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/deprecated_got_revision_mapping.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/deprecated_got_revision_mapping.json @@ -76,8 +76,7 @@ "--revision", "src@refs/heads/main", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_rebase_patch_ref.json b/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_rebase_patch_ref.json index 9d0b17571..d8ac40a83 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_rebase_patch_ref.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_rebase_patch_ref.json @@ -16,8 +16,7 @@ "/path/to/tmp/json", "--revision", "src@HEAD", - "--gerrit_no_rebase_patch_ref", - "--disable-syntax-validation" + "--gerrit_no_rebase_patch_ref" ], "env": { "DEPOT_TOOLS_COLLECT_METRICS": "0", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_reset.json b/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_reset.json index ea906adee..9243a6bf0 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_reset.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/gerrit_no_reset.json @@ -16,8 +16,7 @@ "/path/to/tmp/json", "--revision", "src@HEAD", - "--gerrit_no_reset", - "--disable-syntax-validation" + "--gerrit_no_reset" ], "env": { "DEPOT_TOOLS_COLLECT_METRICS": "0", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/input_commit_with_id_without_repo.json b/recipes/recipe_modules/bot_update/examples/full.expected/input_commit_with_id_without_repo.json index aad3ae1da..b4cff0503 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/input_commit_with_id_without_repo.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/input_commit_with_id_without_repo.json @@ -15,8 +15,7 @@ "--output_json", "/path/to/tmp/json", "--revision", - "src@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", - "--disable-syntax-validation" + "src@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" ], "env": { "DEPOT_TOOLS_COLLECT_METRICS": "0", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/multiple_patch_refs.json b/recipes/recipe_modules/bot_update/examples/full.expected/multiple_patch_refs.json index 7fe905403..5c71466a5 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/multiple_patch_refs.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/multiple_patch_refs.json @@ -19,8 +19,7 @@ "--patch_ref", "https://chromium.googlesource.com/v8/v8@refs/changes/124/45/6", "--revision", - "src@HEAD", - "--disable-syntax-validation" + "src@HEAD" ], "env": { "DEPOT_TOOLS_COLLECT_METRICS": "0", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/no_apply_patch_on_gclient.json b/recipes/recipe_modules/bot_update/examples/full.expected/no_apply_patch_on_gclient.json index ffc8b66ef..260856387 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/no_apply_patch_on_gclient.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/no_apply_patch_on_gclient.json @@ -76,8 +76,7 @@ "--revision", "src@HEAD", "--revision", - "src/third_party/angle@refs/heads/main", - "--disable-syntax-validation" + "src/third_party/angle@refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_HEAD.json b/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_HEAD.json index a98a36086..f6a42235f 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_HEAD.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_HEAD.json @@ -17,8 +17,7 @@ "--revision", "src@HEAD", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_a_branch_head.json b/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_a_branch_head.json index bbf691e1d..995c7871d 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_a_branch_head.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_a_branch_head.json @@ -17,8 +17,7 @@ "--revision", "src@refs/branch-heads/x", "--refs", - "refs/branch-heads/x", - "--disable-syntax-validation" + "refs/branch-heads/x" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_a_specific_commit.json b/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_a_specific_commit.json index c917eff40..69edaebe6 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_a_specific_commit.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_a_specific_commit.json @@ -17,8 +17,7 @@ "--revision", "src@aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_main.json b/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_main.json index 6c95cf6f3..b4aa5330e 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_main.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/no_cp_checkout_main.json @@ -17,8 +17,7 @@ "--revision", "src@refs/heads/main", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/origin_main.json b/recipes/recipe_modules/bot_update/examples/full.expected/origin_main.json index 4820e0815..00645fc93 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/origin_main.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/origin_main.json @@ -17,8 +17,7 @@ "--revision", "src@origin/main", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/refs.json b/recipes/recipe_modules/bot_update/examples/full.expected/refs.json index d2d55ba79..906abe4e6 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/refs.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/refs.json @@ -17,8 +17,7 @@ "--revision", "src@HEAD", "--refs", - "+refs/change/1/2/333", - "--disable-syntax-validation" + "+refs/change/1/2/333" ], "env": { "DEPOT_TOOLS_COLLECT_METRICS": "0", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/reset_root_solution_revision.json b/recipes/recipe_modules/bot_update/examples/full.expected/reset_root_solution_revision.json index 52093ffe2..473067554 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/reset_root_solution_revision.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/reset_root_solution_revision.json @@ -15,8 +15,7 @@ "--output_json", "/path/to/tmp/json", "--revision", - "src@b0ff6a5b8b2bd8a31e9b5e29710da5275f0a9322", - "--disable-syntax-validation" + "src@b0ff6a5b8b2bd8a31e9b5e29710da5275f0a9322" ], "env": { "DEPOT_TOOLS_COLLECT_METRICS": "0", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/resolve_chromium_fixed_version.json b/recipes/recipe_modules/bot_update/examples/full.expected/resolve_chromium_fixed_version.json index 5e94c47c2..c03f56d96 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/resolve_chromium_fixed_version.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/resolve_chromium_fixed_version.json @@ -17,8 +17,7 @@ "--revision", "src@2d72510e447ab60a9728aeea2362d8be2cbd7789", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/revision_fallback_chain_set_output_commit.json b/recipes/recipe_modules/bot_update/examples/full.expected/revision_fallback_chain_set_output_commit.json index 028bfd0c0..bb9ac32d2 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/revision_fallback_chain_set_output_commit.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/revision_fallback_chain_set_output_commit.json @@ -15,8 +15,7 @@ "--output_json", "/path/to/tmp/json", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/revision_specifying_ref.json b/recipes/recipe_modules/bot_update/examples/full.expected/revision_specifying_ref.json index c905c47d3..324ee8410 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/revision_specifying_ref.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/revision_specifying_ref.json @@ -19,8 +19,7 @@ "--refs", "refs/heads/main", "--refs", - "refs/branch-heads/4000", - "--disable-syntax-validation" + "refs/branch-heads/4000" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/ci/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail.json b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail.json index dc3859d30..00e570c50 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail.json @@ -76,8 +76,7 @@ "--revision", "src@refs/heads/main", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch.json b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch.json index e6698164d..5a42d167f 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch.json @@ -76,8 +76,7 @@ "--revision", "src@refs/heads/main", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch_download.json b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch_download.json index 00a05c75c..8cee3b6df 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch_download.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_fail_patch_download.json @@ -76,8 +76,7 @@ "--revision", "src@refs/heads/main", "--refs", - "refs/heads/main", - "--disable-syntax-validation" + "refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_angle.json b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_angle.json index ffc8b66ef..260856387 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_angle.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_angle.json @@ -76,8 +76,7 @@ "--revision", "src@HEAD", "--revision", - "src/third_party/angle@refs/heads/main", - "--disable-syntax-validation" + "src/third_party/angle@refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_branch_heads.json b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_branch_heads.json index 50b931fd1..bf26b1255 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_branch_heads.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_branch_heads.json @@ -76,8 +76,7 @@ "--revision", "src@refs/branch-heads/67", "--refs", - "refs/branch-heads/67", - "--disable-syntax-validation" + "refs/branch-heads/67" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_feature_branch.json b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_feature_branch.json index dc591d5a8..37bd9a61d 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_feature_branch.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_feature_branch.json @@ -76,8 +76,7 @@ "--revision", "src@refs/heads/experimental/feature", "--refs", - "refs/heads/experimental/feature", - "--disable-syntax-validation" + "refs/heads/experimental/feature" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_v8_feature_branch.json b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_v8_feature_branch.json index 8cbda2ed5..9ad0e9f9e 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_v8_feature_branch.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_v8_feature_branch.json @@ -76,8 +76,7 @@ "--revision", "src@HEAD", "--revision", - "src/v8@refs/heads/experimental/feature", - "--disable-syntax-validation" + "src/v8@refs/heads/experimental/feature" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json index 41d0057b6..5665377d5 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_gerrit_webrtc.json @@ -76,8 +76,7 @@ "--revision", "src@HEAD", "--revision", - "src/third_party/webrtc@refs/heads/main", - "--disable-syntax-validation" + "src/third_party/webrtc@refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8.json b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8.json index 31a02c674..c103e7a35 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8.json @@ -76,8 +76,7 @@ "--revision", "src@HEAD", "--revision", - "src/v8@abc", - "--disable-syntax-validation" + "src/v8@abc" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json index 0510ff58c..e5bf30d8f 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/tryjob_v8_head_by_default.json @@ -76,8 +76,7 @@ "--revision", "src@HEAD", "--revision", - "src/v8@refs/heads/main", - "--disable-syntax-validation" + "src/v8@refs/heads/main" ], "env": { "DEPOT_TOOLS_REPORT_BUILD": "chromium/src/try/linux/8945511751514863184", diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/with_experiments.json b/recipes/recipe_modules/bot_update/examples/full.expected/with_experiments.json index b4b1f84da..e05b2e176 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/with_experiments.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/with_experiments.json @@ -16,7 +16,6 @@ "/path/to/tmp/json", "--revision", "src@HEAD", - "--disable-syntax-validation", "--experiments=no_sync,cool_experiment" ], "env": { diff --git a/recipes/recipe_modules/bot_update/examples/full.expected/with_tags.json b/recipes/recipe_modules/bot_update/examples/full.expected/with_tags.json index 614dccee2..13368fce5 100644 --- a/recipes/recipe_modules/bot_update/examples/full.expected/with_tags.json +++ b/recipes/recipe_modules/bot_update/examples/full.expected/with_tags.json @@ -16,8 +16,7 @@ "/path/to/tmp/json", "--revision", "src@HEAD", - "--with_tags", - "--disable-syntax-validation" + "--with_tags" ], "env": { "DEPOT_TOOLS_COLLECT_METRICS": "0", diff --git a/recipes/recipe_modules/bot_update/examples/full.py b/recipes/recipe_modules/bot_update/examples/full.py index f0acdbc25..1d8372268 100644 --- a/recipes/recipe_modules/bot_update/examples/full.py +++ b/recipes/recipe_modules/bot_update/examples/full.py @@ -79,7 +79,6 @@ def RunSteps(api): suffix=suffix, gerrit_no_reset=gerrit_no_reset, gerrit_no_rebase_patch_ref=gerrit_no_rebase_patch_ref, - disable_syntax_validation=True, patch_refs=patch_refs, add_blamelists=add_blamelists, set_output_commit=set_output_commit, diff --git a/recipes/recipe_modules/gclient/config.py b/recipes/recipe_modules/gclient/config.py index fe58d6173..7ace135cc 100644 --- a/recipes/recipe_modules/gclient/config.py +++ b/recipes/recipe_modules/gclient/config.py @@ -104,8 +104,6 @@ def BaseConfig(USE_MIRROR=True, CACHE_DIR=None, required=False, hidden=True), - disable_syntax_validation = Single(bool, empty_val=False, required=False), - USE_MIRROR = Static(bool(USE_MIRROR)), BUILDSPEC_VERSION= Static(BUILDSPEC_VERSION, hidden=True), ) @@ -119,10 +117,6 @@ def ChromiumGitURL(_c, *pieces): def ChromeInternalGitURL(_c, *pieces): # pragma: no cover return '/'.join(('https://chrome-internal.googlesource.com',) + pieces) -@config_ctx() -def disable_syntax_validation(c): - c.disable_syntax_validation = True - @config_ctx() def android(c): c.target_os.add('android') diff --git a/recipes/recipe_modules/gclient/examples/full.py b/recipes/recipe_modules/gclient/examples/full.py index b521dec0b..37fd57750 100644 --- a/recipes/recipe_modules/gclient/examples/full.py +++ b/recipes/recipe_modules/gclient/examples/full.py @@ -25,7 +25,6 @@ TEST_CONFIGS = [ 'custom_tabs_client', 'dart', 'dawn', - 'disable_syntax_validation', 'emscripten_releases', 'expect_tests', 'gerrit',