Revert "add "generic" infra path config"
This reverts commit 8b5b594115.
Reason for revert: nothing wrong with this CL, but implementing a manual roll to build.git takes more than 20 min. I will reland this CL once my roll to build.git CL is ready
Original change's description:
> add "generic" infra path config
> 
> It proved to be dangerous to introduce conditional logic into recipes
> and recipe modules to alternate between buildbot and luci modes, namely
> it touches buildbot code paths, which can be very dangerous.
> 
> Instead, introduce "generic" default path config that configures
> existing base paths from the built-in ones.
> 
> Also remove swarmbucket path config because it is not used.
> 
> R=iannucci@chromium.org
> BUG=660481
> 
> Change-Id: Ide0e1f64913fe35766b997ab5b55f01f4c63aa58
> Reviewed-on: https://chromium-review.googlesource.com/459234
> Commit-Queue: Nodir Turakulov <nodir@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> 
TBR=iannucci@chromium.org,nodir@chromium.org,chromium-reviews@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=660481
Change-Id: If27a537689dfe3669015bcbc7a5f07ca1f5c10af
Reviewed-on: https://chromium-review.googlesource.com/461223
Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Nodir Turakulov <nodir@chromium.org>
			
			
				changes/23/461223/2
			
			
		
							parent
							
								
									8b5b594115
								
							
						
					
					
						commit
						284e34ae28
					
				@ -1,15 +0,0 @@
 | 
			
		||||
[
 | 
			
		||||
  {
 | 
			
		||||
    "cmd": [],
 | 
			
		||||
    "name": "show cache path",
 | 
			
		||||
    "~followup_annotations": [
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'builder'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git'), 'tmp_base': ('/',)}@@@",
 | 
			
		||||
      "@@@STEP_LOG_END@result@@@"
 | 
			
		||||
    ]
 | 
			
		||||
  },
 | 
			
		||||
  {
 | 
			
		||||
    "name": "$result",
 | 
			
		||||
    "recipe_result": null,
 | 
			
		||||
    "status_code": 0
 | 
			
		||||
  }
 | 
			
		||||
]
 | 
			
		||||
@ -1,15 +0,0 @@
 | 
			
		||||
[
 | 
			
		||||
  {
 | 
			
		||||
    "cmd": [],
 | 
			
		||||
    "name": "show cache path",
 | 
			
		||||
    "~followup_annotations": [
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'builder'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git'), 'tmp_base': ('/',)}@@@",
 | 
			
		||||
      "@@@STEP_LOG_END@result@@@"
 | 
			
		||||
    ]
 | 
			
		||||
  },
 | 
			
		||||
  {
 | 
			
		||||
    "name": "$result",
 | 
			
		||||
    "recipe_result": null,
 | 
			
		||||
    "status_code": 0
 | 
			
		||||
  }
 | 
			
		||||
]
 | 
			
		||||
@ -1,15 +0,0 @@
 | 
			
		||||
[
 | 
			
		||||
  {
 | 
			
		||||
    "cmd": [],
 | 
			
		||||
    "name": "show cache path",
 | 
			
		||||
    "~followup_annotations": [
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'builder'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git'), 'tmp_base': ('/',)}@@@",
 | 
			
		||||
      "@@@STEP_LOG_END@result@@@"
 | 
			
		||||
    ]
 | 
			
		||||
  },
 | 
			
		||||
  {
 | 
			
		||||
    "name": "$result",
 | 
			
		||||
    "recipe_result": null,
 | 
			
		||||
    "status_code": 0
 | 
			
		||||
  }
 | 
			
		||||
]
 | 
			
		||||
@ -1,15 +0,0 @@
 | 
			
		||||
[
 | 
			
		||||
  {
 | 
			
		||||
    "cmd": [],
 | 
			
		||||
    "name": "show cache path",
 | 
			
		||||
    "~followup_annotations": [
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'builder'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git'), 'tmp_base': ('/',)}@@@",
 | 
			
		||||
      "@@@STEP_LOG_END@result@@@"
 | 
			
		||||
    ]
 | 
			
		||||
  },
 | 
			
		||||
  {
 | 
			
		||||
    "name": "$result",
 | 
			
		||||
    "recipe_result": null,
 | 
			
		||||
    "status_code": 0
 | 
			
		||||
  }
 | 
			
		||||
]
 | 
			
		||||
@ -1,15 +0,0 @@
 | 
			
		||||
[
 | 
			
		||||
  {
 | 
			
		||||
    "cmd": [],
 | 
			
		||||
    "name": "show cache path",
 | 
			
		||||
    "~followup_annotations": [
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'builder'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git'), 'tmp_base': ('/',)}@@@",
 | 
			
		||||
      "@@@STEP_LOG_END@result@@@"
 | 
			
		||||
    ]
 | 
			
		||||
  },
 | 
			
		||||
  {
 | 
			
		||||
    "name": "$result",
 | 
			
		||||
    "recipe_result": null,
 | 
			
		||||
    "status_code": 0
 | 
			
		||||
  }
 | 
			
		||||
]
 | 
			
		||||
@ -1,15 +0,0 @@
 | 
			
		||||
[
 | 
			
		||||
  {
 | 
			
		||||
    "cmd": [],
 | 
			
		||||
    "name": "show cache path",
 | 
			
		||||
    "~followup_annotations": [
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@base_paths: {'builder_cache': ('/', 'b', 'c', 'builder'), 'cache': ('/', 'b', 'c'), 'goma_cache': ('/', 'b', 'c', 'goma'), 'start_dir': ('/', 'b', 'FakeTestingCWD'), 'git_cache': ('/', 'b', 'c', 'git'), 'tmp_base': ('/',)}@@@",
 | 
			
		||||
      "@@@STEP_LOG_END@result@@@"
 | 
			
		||||
    ]
 | 
			
		||||
  },
 | 
			
		||||
  {
 | 
			
		||||
    "name": "$result",
 | 
			
		||||
    "recipe_result": null,
 | 
			
		||||
    "status_code": 0
 | 
			
		||||
  }
 | 
			
		||||
]
 | 
			
		||||
@ -0,0 +1,16 @@
 | 
			
		||||
[
 | 
			
		||||
  {
 | 
			
		||||
    "cmd": [],
 | 
			
		||||
    "name": "show cache path",
 | 
			
		||||
    "~followup_annotations": [
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@[CACHE]@@@",
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@[GIT_CACHE]@@@",
 | 
			
		||||
      "@@@STEP_LOG_END@result@@@"
 | 
			
		||||
    ]
 | 
			
		||||
  },
 | 
			
		||||
  {
 | 
			
		||||
    "name": "$result",
 | 
			
		||||
    "recipe_result": null,
 | 
			
		||||
    "status_code": 0
 | 
			
		||||
  }
 | 
			
		||||
]
 | 
			
		||||
@ -0,0 +1,16 @@
 | 
			
		||||
[
 | 
			
		||||
  {
 | 
			
		||||
    "cmd": [],
 | 
			
		||||
    "name": "show cache path",
 | 
			
		||||
    "~followup_annotations": [
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@[CACHE]@@@",
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@[GIT_CACHE]@@@",
 | 
			
		||||
      "@@@STEP_LOG_END@result@@@"
 | 
			
		||||
    ]
 | 
			
		||||
  },
 | 
			
		||||
  {
 | 
			
		||||
    "name": "$result",
 | 
			
		||||
    "recipe_result": null,
 | 
			
		||||
    "status_code": 0
 | 
			
		||||
  }
 | 
			
		||||
]
 | 
			
		||||
@ -0,0 +1,16 @@
 | 
			
		||||
[
 | 
			
		||||
  {
 | 
			
		||||
    "cmd": [],
 | 
			
		||||
    "name": "show cache path",
 | 
			
		||||
    "~followup_annotations": [
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@[CACHE]@@@",
 | 
			
		||||
      "@@@STEP_LOG_LINE@result@[GIT_CACHE]@@@",
 | 
			
		||||
      "@@@STEP_LOG_END@result@@@"
 | 
			
		||||
    ]
 | 
			
		||||
  },
 | 
			
		||||
  {
 | 
			
		||||
    "name": "$result",
 | 
			
		||||
    "recipe_result": null,
 | 
			
		||||
    "status_code": 0
 | 
			
		||||
  }
 | 
			
		||||
]
 | 
			
		||||
					Loading…
					
					
				
		Reference in New Issue