From 2403e80b59284948692642af4ca4b53bfbdac176 Mon Sep 17 00:00:00 2001 From: "machenbach@chromium.org" Date: Fri, 29 Apr 2016 12:34:42 +0000 Subject: [PATCH] Reland of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #1 id:1 of https://codereview.chromium.org/1928373002/ ) Reason for revert: Was me - too fast to pull the revert trigger. The CL in question has notry set to true :( Original issue's description: > Revert of git cl try: don't skip presubmit builders, but set dry_run property. (patchset #2 id:20001 of https://codereview.chromium.org/1926663002/ ) > > Reason for revert: > Now only presubmit is scheduled on dry run, example CL: > https://codereview.chromium.org/1804003002 > > Original issue's description: > > Reland of git cl try: don't skip presubmit builders, but set dry_run property. > > > > With a fix: actually set dry_run for presubmit, and don't set it for other builders. > > > > R=machenbach@chromium.org,sergiyb@chromium.org > > BUG=601128,594127,591030 > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300295 > > TBR=sergiyb@chromium.org,tandrii@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=601128,594127,591030 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300337 TBR=sergiyb@chromium.org,tandrii@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=601128,594127,591030 Review-Url: https://codereview.chromium.org/1930363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@300338 0039d316-1c4b-4281-b951-d872f2087c98 --- git_cl.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/git_cl.py b/git_cl.py index bf091b000..9bf60ea29 100755 --- a/git_cl.py +++ b/git_cl.py @@ -337,6 +337,8 @@ def trigger_try_jobs(auth_config, changelist, options, masters, category): 'rietveld': rietveld_url, }, } + if 'presubmit' in builder.lower(): + parameters['properties']['dry_run'] = 'true' if tests: parameters['properties']['testfilter'] = tests if properties: @@ -4316,8 +4318,7 @@ def CMDtry(parser, args): for master, builders in cq_masters.iteritems(): for builder in builders: # Skip presubmit builders, because these will fail without LGTM. - if 'presubmit' not in builder.lower(): - masters.setdefault(master, {})[builder] = ['defaulttests'] + masters.setdefault(master, {})[builder] = ['defaulttests'] if masters: return masters