From 2379632b67abf6e58c17f4a83b5ba6b5f4af7dd7 Mon Sep 17 00:00:00 2001 From: "maruel@chromium.org" Date: Thu, 23 Sep 2010 20:30:38 +0000 Subject: [PATCH] Improve breakpad by adding cwd, fix str(last_tb) and dump what is sent to the user. The user will get an idea of what data is sent. Getting the current working directory is useful to know what checkout was used. the repr(last_tb) call was stripping off a lot of useful information for debugging. TEST=none BUG=none Review URL: http://codereview.chromium.org/3384020 git-svn-id: svn://svn.chromium.org/chrome/trunk/tools/depot_tools@60339 0039d316-1c4b-4281-b951-d872f2087c98 --- breakpad.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/breakpad.py b/breakpad.py index 0a1fc083d..b7d52bb83 100644 --- a/breakpad.py +++ b/breakpad.py @@ -39,12 +39,14 @@ def SendStack(last_tb, stack, url=None): 'user': getpass.getuser(), 'exception': last_tb, 'host': socket.getfqdn(), + 'cwd': os.getcwd(), } try: # That may not always work. params['exception'] = str(last_tb) except: pass + print '\n'.join(' %s: %s' % (k, v[0:50]) for k,v in params.iteritems()) request = urllib.urlopen(url, urllib.urlencode(params)) print request.read() request.close() @@ -58,7 +60,7 @@ def CheckForException(): if last_value and not isinstance(last_value, KeyboardInterrupt): last_tb = getattr(sys, 'last_traceback', None) if last_tb: - SendStack(repr(last_value), ''.join(traceback.format_tb(last_tb))) + SendStack(last_value, ''.join(traceback.format_tb(last_tb))) def Register():